chore: review updates

Author: canerakdas

apps/site/components/Downloads/MinorReleasesTable/index.tsx

@@ -7,6 +7,7 @@ import type { FC } from 'react';
 import Link from '#site/components/Link';
 import { BASE_CHANGELOG_URL } from '#site/next.constants.mjs';
 import type { MinorVersion } from '#site/types';
+import { chunk } from '#site/util/arrayUtils';
 import { getNodeApiLink } from '#site/util/getNodeApiLink';
 
 import styles from './index.module.css';
@@ -15,21 +16,14 @@ type MinorReleasesTableProps = {
   releases: Array<MinorVersion>;
 };
 
-const chunkedReleases = (releases: Array<MinorVersion>, size: number) => {
-  const count = Math.ceil(releases.length / size);
-
-  return Array.from({ length: count }, (_, index) =>
-    releases.slice(index * size, (index + 1) * size)
-  );
-};
-
 export const MinorReleasesTable: FC<MinorReleasesTableProps> = ({
   releases,
 }) => {
   const t = useTranslations('components.minorReleasesTable');
+
   // Chunk minor releases into groups of 8 for scrollable display.
   // This is to ensure that the table does not become too wide and remains user-friendly
-  const releaseGroups = chunkedReleases(releases, 8);
+  const releaseGroups = chunk(releases, 8);
 
   return (
     <div className={styles.scrollable}>

apps/site/components/withDownloadArchive.tsx

@@ -22,7 +22,6 @@ const WithDownloadArchive: FC<WithDownloadArchiveProps> = async ({
   children: Component,
 }) => {
   const { pathname } = getClientContext();
-  const releaseData = await getReleaseData();
 
   // Extract version from pathname
   const version = extractVersionFromPath(pathname);
@@ -32,6 +31,7 @@ const WithDownloadArchive: FC<WithDownloadArchiveProps> = async ({
   }
 
   // Find the release data for the given version
+  const releaseData = await getReleaseData();
   const release = findReleaseByVersion(releaseData, version);
 
   if (!release) {

apps/site/util/__tests__/getNodeDownloadUrl.test.mjs

@@ -8,48 +8,36 @@ const version = 'v18.16.0';
 describe('getNodeDownloadUrl', () => {
   it('should return the correct download URL for Mac', () => {
     const os = 'MAC';
-    const bitness = 86;
+    const platform = 86;
     const expectedUrl = 'https://nodejs.org/dist/v18.16.0/node-v18.16.0.pkg';
 
-    assert.equal(
-      getNodeDownloadUrl({ version: version, os: os, platform: bitness }),
-      expectedUrl
-    );
+    assert.equal(getNodeDownloadUrl({ version, os, platform }), expectedUrl);
   });
 
   it('should return the correct download URL for Windows (32-bit)', () => {
     const os = 'WIN';
-    const bitness = 86;
+    const platform = 86;
     const expectedUrl =
       'https://nodejs.org/dist/v18.16.0/node-v18.16.0-x86.msi';
 
-    assert.equal(
-      getNodeDownloadUrl({ version: version, os: os, platform: bitness }),
-      expectedUrl
-    );
+    assert.equal(getNodeDownloadUrl({ version, os, platform }), expectedUrl);
   });
 
   it('should return the correct download URL for Windows (64-bit)', () => {
     const os = 'WIN';
-    const bitness = 64;
+    const platform = 64;
     const expectedUrl =
       'https://nodejs.org/dist/v18.16.0/node-v18.16.0-x64.msi';
 
-    assert.equal(
-      getNodeDownloadUrl({ version: version, os: os, platform: bitness }),
-      expectedUrl
-    );
+    assert.equal(getNodeDownloadUrl({ version, os, platform }), expectedUrl);
   });
 
   it('should return the default download URL for other operating systems', () => {
     const os = 'OTHER';
-    const bitness = 86;
+    const platform = 86;
     const expectedUrl = 'https://nodejs.org/dist/v18.16.0/node-v18.16.0.tar.gz';
 
-    assert.equal(
-      getNodeDownloadUrl({ version: version, os: os, platform: bitness }),
-      expectedUrl
-    );
+    assert.equal(getNodeDownloadUrl({ version, os, platform }), expectedUrl);
   });
 
   describe('MAC', () => {

apps/site/util/arrayUtils.ts

@@ -0,0 +1,12 @@
+/**
+ * Splits an array into smaller chunks of a specified size.
+ */
+export const chunk = <T>(array: Array<T>, size: number): Array<Array<T>> => {
+  // Number of chunks needed
+  const count = Math.ceil(array.length / size);
+
+  // Create an array of chunks by slicing the original array
+  return Array.from({ length: count }, (_, index) =>
+    array.slice(index * size, (index + 1) * size)
+  );
+};

apps/site/util/downloadUtils/archive.tsx

@@ -141,7 +141,7 @@ export const extractVersionFromPath = (pathname: string | undefined) => {
   const version = segments.pop();
 
   // Check version format like (v22.0.4 or 'archive')
-  if (!version || (!version.match(/^v\d+(\.\d+)*$/) && version !== 'archive')) {
+  if (!version || !version.match(/^v\d+(\.\d+)*|archive$/)) {
     return null;
   }