Skip to content

Commit 6bc1393

Browse files
committed
expand and do not reuse i18n keys
this helps our features be more portable
1 parent 113334f commit 6bc1393

File tree

2 files changed

+13
-6
lines changed

2 files changed

+13
-6
lines changed

apps/site/components/EOL/Table.tsx

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,13 @@ const EOLTable: FC = async () => {
2121
<table id="tbVulnerabilities" className="download-table full-width">
2222
<thead>
2323
<tr>
24-
{/* TODO @bmuenzenmeyer change these to new i18n keys */}
2524
<th>
26-
{t('components.downloadReleasesTable.version')} (
27-
{t('components.downloadReleasesTable.codename')})
25+
{t('components.eolTable.version')} (
26+
{t('components.eolTable.codename')})
2827
</th>
29-
<th>{t('components.downloadReleasesTable.lastUpdated')}</th>
30-
<th>Vulnerabilities</th>
31-
<th>Details</th>
28+
<th>{t('components.eolTable.lastUpdated')}</th>
29+
<th>{t('components.eolTable.vulnerabilities')}</th>
30+
<th>{t('components.eolTable.details')}</th>
3231
</tr>
3332
</thead>
3433
<tbody>

packages/i18n/src/locales/en.json

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -190,6 +190,14 @@
190190
"details": "Details"
191191
}
192192
},
193+
"eolTable": {
194+
"version": "Version",
195+
"codename": "Codename",
196+
"releaseDate": "Released at",
197+
"lastUpdated": "Last updated",
198+
"vulnerabilities": "Vulnerabilities",
199+
"details": "Details"
200+
},
193201
"minorReleasesTable": {
194202
"version": "Version",
195203
"links": "Links",

0 commit comments

Comments
 (0)