code review

Author: avivkeller

apps/site/components/Downloads/DownloadLink.tsx

@@ -4,8 +4,8 @@ import type { FC, PropsWithChildren } from 'react';
 
 import LinkWithArrow from '#site/components/LinkWithArrow';
 import { useClientContext } from '#site/hooks';
-import type { NodeRelease } from '#site/types';
-import { getNodeDownloadUrl, type DownloadKind } from '#site/util/download';
+import type { DownloadKind, NodeRelease } from '#site/types';
+import { getNodeDownloadUrl } from '#site/util/download';
 import { getUserPlatform } from '#site/util/userAgent';
 
 type DownloadLinkProps = { release: NodeRelease; kind?: DownloadKind };

apps/site/components/Downloads/Release/DownloadLink.tsx

@@ -5,7 +5,7 @@ import { useContext } from 'react';
 
 import DownloadLinkBase from '#site/components/Downloads/DownloadLink';
 import { ReleaseContext } from '#site/providers/releaseProvider';
-import type { DownloadKind } from '#site/util/download';
+import type { DownloadKind } from '#site/types/download';
 
 type DownloadLinkProps = { kind?: DownloadKind };
 

apps/site/components/Downloads/Release/OperatingSystemDropdown.tsx

@@ -7,7 +7,7 @@ import type { FC } from 'react';
 
 import { useClientContext } from '#site/hooks';
 import { ReleaseContext } from '#site/providers/releaseProvider';
-import type { UserOS } from '#site/types/userOS';
+import type { UserOS } from '#site/types/userAgent';
 import { nextItem, OPERATING_SYSTEMS, parseCompat } from '#site/util/download';
 
 type OperatingSystemDropdownProps = { exclude?: Array<UserOS> };

apps/site/components/Downloads/Release/PlatformDropdown.tsx

@@ -7,7 +7,7 @@ import { useEffect, useContext, useMemo } from 'react';
 
 import { useClientContext } from '#site/hooks';
 import { ReleaseContext } from '#site/providers/releaseProvider';
-import type { UserPlatform } from '#site/types/userOS';
+import type { UserPlatform } from '#site/types/userAgent';
 import { PLATFORMS, nextItem, parseCompat } from '#site/util/download';
 import { getUserPlatform } from '#site/util/userAgent';
 

apps/site/hooks/react-client/useDetectOS.ts

@@ -2,7 +2,11 @@
 
 import { useEffect, useState } from 'react';
 
-import type { UserArchitecture, UserBitness, UserOS } from '#site/types/userOS';
+import type {
+  UserArchitecture,
+  UserBitness,
+  UserOS,
+} from '#site/types/userAgent';
 import { getHighEntropyValues, detectOS } from '#site/util/userAgent';
 
 type UserOSState = {

apps/site/hooks/react-client/useNavigationState.ts

@@ -4,7 +4,7 @@ import type { RefObject } from 'react';
 import { useContext, useEffect } from 'react';
 
 import { NavigationStateContext } from '#site/providers/navigationStateProvider';
-import { debounce } from '#site/util/misc';
+import { debounce } from '#site/util/objects';
 
 const useNavigationState = <T extends HTMLElement>(
   id: string,

apps/site/i18n.tsx

@@ -4,7 +4,7 @@ import { getRequestConfig } from 'next-intl/server';
 
 import { availableLocaleCodes, defaultLocale } from '#site/next.locales.mjs';
 
-import { deepMerge } from './util/misc';
+import { deepMerge } from './util/objects';
 
 // Loads the Application Locales/Translations Dynamically
 const loadLocaleDictionary = async (locale: string) => {

apps/site/types/downloads.ts apps/site/types/download.tsapps/site/types/downloads.ts renamed to apps/site/types/download.ts

@@ -3,3 +3,5 @@ export interface DownloadSnippet {
   language: string;
   content: string;
 }
+
+export type DownloadKind = 'installer' | 'binary' | 'source';

apps/site/types/index.ts

@@ -11,4 +11,5 @@ export * from './server';
 export * from './github';
 export * from './calendar';
 export * from './author';
-export * from './downloads';
+export * from './download';
+export * from './userAgent';

apps/site/types/release.ts

@@ -1,6 +1,6 @@
-import type { DownloadSnippet } from '#site/types/downloads';
+import type { DownloadSnippet } from '#site/types/download';
 import type { NodeRelease } from '#site/types/releases';
-import type { UserOS, UserPlatform } from '#site/types/userOS';
+import type { UserOS, UserPlatform } from '#site/types/userAgent';
 
 export type InstallationMethod =
   | 'NVM'