Skip to content

Commit 76b456f

Browse files
authored
Apply suggestions from code review
Signed-off-by: Aviv Keller <me@aviv.sh>
1 parent 10fc21f commit 76b456f

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

.github/workflows/publish-packages.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -108,15 +108,16 @@ jobs:
108108
- name: Set up pnpm
109109
uses: pnpm/action-setup@a7487c7e89a18df4991f7f222e4898a00d66ddda # v4.1.0
110110

111-
- name: Set up Node.js
111+
- name: Setup Node.js
112112
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
113113
with:
114114
# Don't use caching here as we never install dependencies in this workflow
115115
node-version-file: '.nvmrc'
116116
registry-url: 'https://registry.npmjs.org'
117117

118-
- name: Setup npm
119-
# OIDC requires npm >=11.5.1. pnpm will use the installed version of npm for publishing
118+
- name: Re-install npm
119+
# TODO: OIDC requires npm >=11.5.1.
120+
# Until Node.js v24 is LTS (with npm 11 as the default), we need to bump.
120121
run: npm install -g npm@11
121122

122123
- name: Publish

0 commit comments

Comments
 (0)