Skip to content

Commit 7a92ef5

Browse files
committed
feat: fixed header for scrollable table, minor version identifier and stateless select fixes
1 parent 2d7da01 commit 7a92ef5

File tree

4 files changed

+29
-3
lines changed

4 files changed

+29
-3
lines changed

apps/site/components/Downloads/MinorReleasesTable/index.module.css

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,16 @@
1818
flex
1919
max-h-[29rem]
2020
overflow-y-auto;
21+
22+
table {
23+
@apply xs:border-t-0
24+
border-t;
25+
}
26+
27+
th {
28+
@apply xs:border-t
29+
border-neutral-200;
30+
}
2131
}
2232

2333
.information {
@@ -27,3 +37,14 @@
2737
.links {
2838
@apply md:w-44;
2939
}
40+
41+
.stickyHeader {
42+
@apply top-0
43+
z-10
44+
border-t
45+
bg-white
46+
text-left
47+
font-semibold
48+
sm:sticky
49+
dark:bg-neutral-950;
50+
}

apps/site/components/Downloads/MinorReleasesTable/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ const MinorReleasesTable: FC<MinorReleasesTableProps> = ({ releases }) => {
2525
return (
2626
<div className={styles.scrollable}>
2727
<table>
28-
<thead>
28+
<thead className={styles.stickyHeader}>
2929
<tr>
3030
<th>{t('minorReleasesTable.version')}</th>
3131
<th className={styles.information}>

apps/site/util/download/archive.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ export const getDownloadArchiveNavigation = (releases: Array<NodeRelease>) => {
109109
}
110110

111111
acc[status].push({
112-
label: `Node.js v${major} ${codename ? `(${codename})` : ''}`,
112+
label: `Node.js v${major}.x ${codename ? `(${codename})` : ''}`,
113113
value: `/download/${versionWithPrefix}`,
114114
});
115115

packages/ui-components/src/Common/Select/index.module.css

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,12 +161,17 @@
161161
}
162162

163163
.noscript {
164-
@apply relative;
164+
@apply relative
165+
cursor-pointer;
165166

166167
summary {
167168
@apply flex
168169
w-full
169170
justify-between;
171+
172+
span {
173+
@apply pl-0;
174+
}
170175
}
171176

172177
.trigger {

0 commit comments

Comments
 (0)