fix for the codeQL (#4931)

Use 'fs.existSync' and 'fs.writeFileSync' together instead of a callback
functions, because it will make the chance for file changes.

Author: Maledong

scripts/release-post.js

@@ -211,23 +211,21 @@ function writeToFile(results) {
   );
 
   return new Promise((resolve, reject) => {
-    fs.access(filepath, fs.F_OK, (err) => {
-      if (!err && process.argv[3] !== '--force') {
-        return reject(
-          new Error(`Release post for ${results.version} already exists!`)
-        );
-      }
+    if (fs.existsSync(filepath) && process.argv[3] !== '--force') {
+      return reject(
+        new Error(`Release post for ${results.version} already exists!`)
+      );
+    }
 
-      fs.writeFile(filepath, results.content, (err1) => {
-        if (err1) {
-          return reject(
-            new Error(`Failed to write Release post: Reason: ${err1.message}`)
-          );
-        }
+    try {
+      fs.writeFileSync(filepath, results.content);
+    } catch (error) {
+      return reject(
+        new Error(`Failed to write Release post: Reason: ${error.message}`)
+      );
+    }
 
-        resolve(filepath);
-      });
-    });
+    resolve(filepath);
   });
 }
 

tests/scripts/release-post.test.js

@@ -327,8 +327,8 @@ test('writeToFile<object>', (t) => {
   let fileExists;
 
   const fs = {
-    access: (filename, flags, cb) => cb(!fileExists && new Error('ENOENT')),
-    writeFile: (filename, contents, cb) => cb()
+    existsSync: (filepath) => fileExists,
+    writeFileSync: (filepath, contents) => {}
   };
 
   const releasePost = proxyquire('../../scripts/release-post', { fs });