Skip to content

Commit 968e221

Browse files
committed
feat(site): make codename prominent
1 parent fc346a6 commit 968e221

File tree

2 files changed

+9
-8
lines changed
  • apps/site/components/Downloads/ReleaseModal
  • packages/i18n/locales

2 files changed

+9
-8
lines changed

apps/site/components/Downloads/ReleaseModal/index.tsx

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,19 +23,19 @@ const ReleaseModal: FC<ReleaseModalProps> = ({
2323
}) => {
2424
const t = useTranslations();
2525

26-
const modalHeading = t('components.releaseModal.title', {
26+
const modalHeadingKey = release.codename
27+
? 'components.releaseModal.title'
28+
: 'components.releaseModal.titleWithoutCodename';
29+
30+
const modalHeading = t(modalHeadingKey, {
2731
version: release.major,
32+
codename: release.codename ?? '',
2833
});
2934

3035
const releaseAnnounceLink = getReleaseAnnounceLink(release);
3136

3237
return (
33-
<Modal
34-
open={isOpen}
35-
onOpenChange={closeModal}
36-
heading={modalHeading}
37-
subheading={release.codename}
38-
>
38+
<Modal open={isOpen} onOpenChange={closeModal} heading={modalHeading}>
3939
{releaseAnnounceLink && (
4040
<LinkWithArrow href={releaseAnnounceLink}>
4141
{t('components.releaseModal.releaseAnnouncement')}

packages/i18n/locales/en.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,8 @@
156156
"details": "Details"
157157
},
158158
"releaseModal": {
159-
"title": "Node.js v{version} release",
159+
"title": "Node.js {version} ({codename})",
160+
"titleWithoutCodename": "Node.js {version}",
160161
"minorVersions": "Minor versions",
161162
"releaseAnnouncement": "Release Announcement",
162163
"unsupportedVersionWarning": "This version is out of maintenance. Please use a currently supported version."

0 commit comments

Comments
 (0)