fix: hide irrelevant download install options

Signed-off-by: abhijeet nardele <234410808+abhijeetnardele24-hash@users.noreply.github.com>

Author: abhijeetnardele24-hash

apps/site/components/Downloads/Release/InstallationMethodDropdown.tsx

@@ -22,22 +22,30 @@ const InstallationMethodDropdown: FC = () => {
     [release.os, release.version]
   );
 
+  const enabledInstallMethods = useMemo(
+    () => parsedInstallMethods.filter(({ disabled }) => !disabled),
+    [parsedInstallMethods]
+  );
+
   // We group Platforms on the Platform Dropdown to provide the User
   // understanding of what is recommended/official and what is not.
   const grouppedMethods = useMemo(
-    () => [
-      {
-        label: t('layouts.download.dropdown.platformGroups.official'),
-        items: parsedInstallMethods.filter(({ recommended }) => recommended),
-      },
-      {
-        label: t('layouts.download.dropdown.platformGroups.unofficial'),
-        items: parsedInstallMethods.filter(({ recommended }) => !recommended),
-      },
-    ],
+    () =>
+      [
+        {
+          label: t('layouts.download.dropdown.platformGroups.official'),
+          items: enabledInstallMethods.filter(({ recommended }) => recommended),
+        },
+        {
+          label: t('layouts.download.dropdown.platformGroups.unofficial'),
+          items: enabledInstallMethods.filter(
+            ({ recommended }) => !recommended
+          ),
+        },
+      ].filter(({ items }) => items.length > 0),
     // We only want to react on the change of the parsedPlatforms
     // eslint-disable-next-line react-hooks/exhaustive-deps
-    [parsedInstallMethods]
+    [enabledInstallMethods]
   );
 
   useEffect(() => {
@@ -49,28 +57,28 @@ const InstallationMethodDropdown: FC = () => {
         // Sets either the utmost recommended platform or the first non-disabled one
         // Note that the first item of groupped platforms is always the recommended one
         nextItem<InstallationMethod | ''>('', grouppedMethods[0].items) ||
-        nextItem<InstallationMethod | ''>('', parsedInstallMethods);
+        nextItem<InstallationMethod | ''>('', enabledInstallMethods);
 
       // This will never return an empty string as there should always be an item
       // when the OS has finished loading for a given installation method
       release.setInstallMethod(installationMethod as InstallationMethod);
     }
     // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [parsedInstallMethods, release.installMethod, release.os]);
+  }, [enabledInstallMethods, release.installMethod, release.os]);
 
   // We set the Platform to the next available platform when the current
   // one is not valid anymore due to OS or Version changes
   useEffect(
     () => {
       if (release.os !== 'LOADING' && release.installMethod !== '') {
         release.setInstallMethod(
-          nextItem(release.installMethod, parsedInstallMethods)
+          nextItem(release.installMethod, enabledInstallMethods)
         );
       }
     },
     // We only want to react on the change of the OS and Version
     // eslint-disable-next-line react-hooks/exhaustive-deps
-    [release.os, release.version]
+    [enabledInstallMethods, release.os, release.version]
   );
 
   return (

apps/site/util/__tests__/download.test.mjs

@@ -47,6 +47,20 @@ describe('parseCompat', () => {
   });
 
   describe('extended tests', () => {
+    it('should keep nvm available for AIX', () => {
+      const nvm = INSTALL_METHODS.find(({ value }) => value === 'NVM');
+
+      const [result] = parseCompat([nvm], {
+        os: 'AIX',
+        installMethod: 'NVM',
+        platform: 'ppc64',
+        version: 'v24.14.0',
+        release: { status: 'Current' },
+      });
+
+      assert.equal(result.disabled, false);
+    });
+
     it('should disable items if OS is not supported', () => {
       const items = [
         {

apps/site/util/download/constants.json

@@ -129,7 +129,7 @@
       "icon": "NVM",
       "name": "nvm",
       "compatibility": {
-        "os": ["MAC", "LINUX", "OTHER"]
+        "os": ["MAC", "LINUX", "AIX", "OTHER"]
       },
       "recommended": true,
       "url": "https://github.com/nvm-sh/nvm",