Skip to content

Commit e7cdd0f

Browse files
committed
chore: code review changes
1 parent eff1234 commit e7cdd0f

File tree

3 files changed

+14
-15
lines changed

3 files changed

+14
-15
lines changed

.github/CODEOWNERS

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ codecov.yml @nodejs/web-infra
88

99
# Dependencies
1010
pnpm-workspace.yaml @nodejs/nodejs-website @nodejs/web-infra
11-
pnpm-lock.yaml @nodejs/nodejs-website @nodejs/web-infra
11+
pnpm-lock.yaml @nodejs/web-infra
1212

1313
# Framework
1414
apps/site/next.config.mjs @nodejs/web-infra
@@ -30,9 +30,8 @@ apps/site/open-next.config.ts @nodejs/web-infra
3030
apps/site/redirects.json @nodejs/web-infra
3131

3232
# Critical Documents
33-
LICENSE @nodejs/tsc @ovflowd @bmuenzenmeyer
34-
GOVERNANCE.md @nodejs/tsc @ovflowd @bmuenzenmeyer
35-
CONTRIBUTING.md @nodejs/tsc @ovflowd @bmuenzenmeyer
33+
LICENSE @nodejs/tsc
34+
GOVERNANCE.md @nodejs/tsc
3635
CONTRIBUTING.md @nodejs/nodejs-website @nodejs/web-infra
3736
docs @nodejs/nodejs-website @nodejs/web-infra
3837

.github/workflows/build.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ on:
1010
push:
1111
branches:
1212
- main
13-
pull_request:
13+
pull_request_target:
1414
branches:
1515
- main
1616
types:
@@ -33,10 +33,10 @@ env:
3333

3434
jobs:
3535
build:
36-
# This Job should run either on non-`pull_request` events,
37-
# or `pull_request` event with a `labeled` action with a label named `github_actions:pull-request`
36+
# This Job should run either on non-`pull_request_target` events,
37+
# or `pull_request_target` event with a `labeled` action with a label named `github_actions:pull-request`
3838
# since we want to run Website Builds on all these occasions. As this allows us to be certain the that builds are passing
39-
if: github.event_name != 'pull_request' || github.event.label.name == 'github_actions:pull-request'
39+
if: github.event_name != 'pull_request_target' || github.event.label.name == 'github_actions:pull-request'
4040

4141
name: Build on ${{ matrix.os }}
4242
runs-on: ${{ matrix.os }}
@@ -62,7 +62,7 @@ jobs:
6262
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
6363
with:
6464
# Provides the Pull Request commit SHA or the GitHub merge group ref
65-
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.ref }}
65+
ref: ${{ github.event_name == 'pull_request_target' && github.event.pull_request.head.sha || github.ref }}
6666
# We only need to fetch the last commit from the head_ref
6767
# since we're not using the `--filter` operation from turborepo
6868
# We don't use the `--filter` as we always want to force builds regardless of having changes or not
@@ -122,7 +122,7 @@ jobs:
122122
# in order to reduce source wastages and build times.
123123
# Note that we skip full static builds on Crowdin-based Pull Requests as these PRs should only contain translation changes
124124
if: |
125-
(github.event_name == 'pull_request' &&
125+
(github.event_name == 'pull_request_target' &&
126126
github.event.pull_request.head.ref != 'chore/crowdin')
127127
run: node_modules/.bin/turbo deploy ${{ env.TURBO_ARGS }}
128128
env:
@@ -132,12 +132,12 @@ jobs:
132132
NODE_OPTIONS: '--max_old_space_size=4096'
133133
# Used for API requests that require GitHub API scopes
134134
NEXT_GITHUB_API_KEY: ${{ secrets.GITHUB_TOKEN }}
135-
# We want to ensure that static exports for all locales do not occur on `pull_request` events
135+
# We want to ensure that static exports for all locales do not occur on `pull_request_target` events
136136
NEXT_PUBLIC_STATIC_EXPORT_LOCALE: false
137137

138138
- name: Sync Orama Cloud
139139
# We only want to sync the Orama Cloud production indexes on `push` events.
140-
# We also want to sync the Orama Cloud preview (deployment) indexes on `pull_request` events (or manual triggers).
140+
# We also want to sync the Orama Cloud preview (deployment) indexes on `pull_request_target` events (or manual triggers).
141141
# We also want to ensure that the sync only happens on the `ubuntu-latest` runner to avoid duplicate syncs
142142
# or Windows-based path issues.
143143
env:

.github/workflows/chromatic.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ on:
1414
paths:
1515
- packages/ui-components/**
1616
- .github/workflows/chromatic.yml
17-
pull_request:
17+
pull_request_target:
1818
branches:
1919
- main
2020
paths:
@@ -38,7 +38,7 @@ jobs:
3838
# We only need to run Storybook Builds and Storybook Visual Regression Tests within Pull Requests that actually
3939
# introduce changes to the Storybook. Hence, we skip running these on Crowdin PRs and Dependabot PRs
4040
if: |
41-
github.event_name != 'pull_request' ||
41+
github.event_name != 'pull_request_target' ||
4242
(
4343
github.event.label.name == 'github_actions:pull-request' &&
4444
github.actor != 'dependabot[bot]' &&
@@ -62,7 +62,7 @@ jobs:
6262
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
6363
with:
6464
# Provides the Pull Request commit SHA or the GitHub merge group ref
65-
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.ref }}
65+
ref: ${{ github.event_name == 'pull_request_target' && github.event.pull_request.head.sha || github.ref }}
6666
# The Chromatic (@chromaui/action) Action requires a full history of the current branch in order to be able to compare
6767
# previous changes and previous commits and determine which Storybooks should be tested against and what should be built
6868
fetch-depth: 0

0 commit comments

Comments
 (0)