Skip to content

Commit e8c2872

Browse files
committed
feat: format datetimes
1 parent ed0092f commit e8c2872

5 files changed

Lines changed: 20 additions & 22 deletions

File tree

apps/site/components/Downloads/DownloadReleasesTable/index.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import Badge from '@node-core/ui-components/Common/Badge';
22
import { getTranslations } from 'next-intl/server';
33
import type { FC } from 'react';
44

5+
import FormattedTime from '@/components/Common/FormattedTime';
56
import DetailsButton from '@/components/Downloads/DownloadReleasesTable/DetailsButton';
67
import getReleaseData from '@/next-data/releaseData';
78

@@ -31,10 +32,10 @@ const DownloadReleasesTable: FC = async () => {
3132
<td data-label="Version">v{release.major}</td>
3233
<td data-label="LTS">{release.codename || '-'}</td>
3334
<td data-label="Date">
34-
<time>{release.currentStart}</time>
35+
<FormattedTime date={release.currentStart} />
3536
</td>
3637
<td data-label="Date">
37-
<time>{release.releaseDate}</time>
38+
<FormattedTime date={release.releaseDate} />
3839
</td>
3940
<td data-label="Status">
4041
<Badge

apps/site/components/Downloads/ReleaseOverview/index.module.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
gap-2;
2323

2424
h1 {
25-
@apply text-base
25+
@apply text-sm
2626
font-semibold;
2727
}
2828

apps/site/components/Downloads/ReleaseOverview/index.tsx

Lines changed: 12 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import {
77
import { useTranslations } from 'next-intl';
88
import type { FC, ReactNode } from 'react';
99

10+
import FormattedTime from '@/components/Common/FormattedTime';
1011
import type { NodeRelease } from '@/types';
1112

1213
import styles from './index.module.css';
@@ -41,16 +42,14 @@ export const ReleaseOverview: FC<ReleaseOverviewProps> = ({ release }) => {
4142
<div className={styles.container}>
4243
<Item
4344
icon={<CalendarIcon />}
44-
title={release.currentStart}
45+
title={<FormattedTime date={release.currentStart} />}
4546
subtitle={t('components.releaseOverview.firstReleased')}
4647
/>
47-
{release.releaseDate && (
48-
<Item
49-
icon={<ClockIcon />}
50-
title={release.releaseDate}
51-
subtitle={t('components.releaseOverview.lastUpdated')}
52-
/>
53-
)}
48+
<Item
49+
icon={<ClockIcon />}
50+
title={<FormattedTime date={release.releaseDate} />}
51+
subtitle={t('components.releaseOverview.lastUpdated')}
52+
/>
5453
<Item
5554
icon={<Square3Stack3DIcon />}
5655
title={release.minorVersions.length}
@@ -70,13 +69,11 @@ export const ReleaseOverview: FC<ReleaseOverviewProps> = ({ release }) => {
7069
subtitle={t('components.releaseOverview.npmVersion')}
7170
/>
7271
)}
73-
{release.v8 && (
74-
<Item
75-
icon={<CodeBracketSquareIcon />}
76-
title={`v${release.v8}`}
77-
subtitle={t('components.releaseOverview.v8Version')}
78-
/>
79-
)}
72+
<Item
73+
icon={<CodeBracketSquareIcon />}
74+
title={`v${release.v8}`}
75+
subtitle={t('components.releaseOverview.v8Version')}
76+
/>
8077
</div>
8178
</div>
8279
);

apps/site/next-data/generators/releaseData.mjs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,8 @@ const generateReleaseData = async () => {
8383
codename: major.support.codename || '',
8484
isLts: status === 'LTS',
8585
npm: latestVersion.dependencies.npm || '',
86-
v8: latestVersion.dependencies.v8 || '',
87-
releaseDate: latestVersion.releaseDate || '',
86+
v8: latestVersion.dependencies.v8,
87+
releaseDate: latestVersion.releaseDate,
8888
modules: latestVersion.modules.version || '',
8989
minorVersions,
9090
};

apps/site/types/releases.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ export interface NodeReleaseSource {
1414
maintenanceStart?: string;
1515
endOfLife: string;
1616
npm?: string;
17-
v8?: string;
18-
releaseDate?: string;
17+
v8: string;
18+
releaseDate: string;
1919
modules?: string;
2020
}
2121

0 commit comments

Comments
 (0)