Merge branch 'main' into feat/simplified-download

Author: canerakdas

.github/scripts/report-inactive-collaborators.mjs

@@ -15,6 +15,20 @@ const getDateMonthsAgo = (months = CONFIG.INACTIVE_MONTHS) => {
   return date.toISOString().split('T')[0];
 };
 
+// Check if there's already an open issue
+async function hasOpenIssue(github, context) {
+  const { owner, repo } = context.repo;
+  const { data: issues } = await github.rest.issues.listForRepo({
+    owner,
+    repo,
+    state: 'open',
+    labels: CONFIG.ISSUE_LABELS[1],
+    per_page: 1,
+  });
+
+  return issues.length > 0;
+}
+
 // Parse collaborator usernames from governance file
 async function parseCollaborators() {
   const content = await readFile(CONFIG.GOVERNANCE_FILE, 'utf8');
@@ -41,12 +55,20 @@ async function getInactiveUsers(github, usernames, repo, cutoffDate) {
   const inactiveUsers = [];
 
   for (const username of usernames) {
-    const { data } = await github.rest.search.commits({
+    // Check commits
+    const { data: commits } = await github.rest.search.commits({
       q: `author:${username} repo:${repo} committer-date:>=${cutoffDate}`,
       per_page: 1,
     });
 
-    if (data.total_count === 0) {
+    // Check issues and PRs
+    const { data: issues } = await github.rest.search.issuesAndPullRequests({
+      q: `involves:${username} repo:${repo} updated:>=${cutoffDate}`,
+      per_page: 1,
+    });
+
+    // User is inactive if they have no commits AND no issues/PRs
+    if (commits.total_count === 0 && issues.total_count === 0) {
       inactiveUsers.push(username);
     }
   }
@@ -75,37 +97,25 @@ ${inactiveMembers.map(m => `| @${m} |`).join('\n')}
 @nodejs/nodejs-website should review this list and contact inactive collaborators to confirm their continued interest in participating in the project.`;
 }
 
-async function createOrUpdateIssue(github, context, report) {
+async function createIssue(github, context, report) {
   if (!report) return;
 
   const { owner, repo } = context.repo;
-  const { data: issues } = await github.rest.issues.listForRepo({
+  await github.rest.issues.create({
     owner,
     repo,
-    state: 'open',
-    labels: CONFIG.ISSUE_LABELS[1],
-    per_page: 1,
+    title: CONFIG.ISSUE_TITLE,
+    body: report,
+    labels: CONFIG.ISSUE_LABELS,
   });
-
-  if (issues.total_count > 0) {
-    await github.rest.issues.update({
-      owner,
-      repo,
-      issue_number: issues.items[0].number,
-      body: report,
-    });
-  } else {
-    await github.rest.issues.create({
-      owner,
-      repo,
-      title: CONFIG.ISSUE_TITLE,
-      body: report,
-      labels: CONFIG.ISSUE_LABELS,
-    });
-  }
 }
 
 export default async function (github, context) {
+  // Check for existing open issue first - exit early if one exists
+  if (await hasOpenIssue(github, context)) {
+    return;
+  }
+
   const cutoffDate = getDateMonthsAgo();
   const collaborators = await parseCollaborators();
 
@@ -117,5 +127,5 @@ export default async function (github, context) {
   );
   const report = formatReport(inactiveMembers, cutoffDate);
 
-  await createOrUpdateIssue(github, context, report);
+  await createIssue(github, context, report);
 }

.github/workflows/codeql.yml

@@ -50,7 +50,7 @@ jobs:
 
       # Initializes the CodeQL tools for scanning.
       - name: Initialize CodeQL
-        uses: github/codeql-action/init@60168efe1c415ce0f5521ea06d5c2062adbeed1b # v3.28.17
+        uses: github/codeql-action/init@ff0a06e83cb2de871e5a09832bc6a81e7276941f # v3.28.18
         with:
           languages: ${{ matrix.language }}
           # If you wish to specify custom queries, you can do so here or in a config file.
@@ -60,7 +60,7 @@ jobs:
       # Autobuild attempts to build any compiled languages  (C/C++, C#, or Java).
       # If this step fails, then you should remove it and run the build manually (see below)
       - name: Autobuild
-        uses: github/codeql-action/autobuild@60168efe1c415ce0f5521ea06d5c2062adbeed1b # v3.28.17
+        uses: github/codeql-action/autobuild@ff0a06e83cb2de871e5a09832bc6a81e7276941f # v3.28.18
 
       # ℹ️ Command-line programs to run using the OS shell.
       # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
@@ -73,6 +73,6 @@ jobs:
       #   ./location_of_script_within_repo/buildscript.sh
 
       - name: Perform CodeQL Analysis
-        uses: github/codeql-action/analyze@60168efe1c415ce0f5521ea06d5c2062adbeed1b # v3.28.17
+        uses: github/codeql-action/analyze@ff0a06e83cb2de871e5a09832bc6a81e7276941f # v3.28.18
         with:
           category: '/language:${{matrix.language}}'

.github/workflows/dependency-review.yml

@@ -34,4 +34,4 @@ jobs:
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
 
       - name: Review Dependencies
-        uses: actions/dependency-review-action@ce3cf9537a52e8119d91fd484ab5b8a807627bf8 # v4.6.0
+        uses: actions/dependency-review-action@da24556b548a50705dd671f47852072ea4c105d9 # v4.7.1

.github/workflows/find-inactive-collaborators.yml

@@ -2,8 +2,7 @@ name: Find inactive collaborators
 
 on:
   schedule:
-    # Run every Monday at 4:05 AM UTC.
-    - cron: 5 4 * * 1
+    - cron: '0 0 1 * *' # Runs at 00:00 UTC on the 1st day of every month
 
   workflow_dispatch:
 

.github/workflows/lint-and-tests.yml

@@ -147,12 +147,12 @@ jobs:
 
       - name: Upload test coverage to Codecov
         if: ${{ !cancelled() && github.event_name != 'merge_group' }}
-        uses: codecov/codecov-action@ad3126e916f78f00edff4ed0317cf185271ccc2d # v5.4.2
+        uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # v5.4.3
         with:
           files: ./apps/site/lcov.info,./packages/*/lcov.info
 
       - name: Upload test results to Codecov
         if: ${{ !cancelled() && github.event_name != 'merge_group' }}
-        uses: codecov/test-results-action@f2dba722c67b86c6caa034178c6e4d35335f6706 # v1.1.0
+        uses: codecov/test-results-action@47f89e9acb64b76debcd5ea40642d25a4adced9f # v1.1.1
         with:
           files: ./apps/site/junit.xml,./packages/*/junit.xml

.github/workflows/playwright-cloudflare-open-next.yml

@@ -35,6 +35,8 @@ jobs:
 
       - name: Git Checkout
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+        with:
+          fetch-depth: 2
 
       - name: Set up pnpm
         uses: pnpm/action-setup@a7487c7e89a18df4991f7f222e4898a00d66ddda # v4.1.0

.github/workflows/playwright.yml

@@ -61,6 +61,8 @@ jobs:
 
       - name: Git Checkout
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+        with:
+          fetch-depth: 2
 
       - name: Set up pnpm
         uses: pnpm/action-setup@a7487c7e89a18df4991f7f222e4898a00d66ddda # v4.1.0

.github/workflows/scorecard.yml

@@ -42,7 +42,7 @@ jobs:
           persist-credentials: false
 
       - name: Run Scorecard Analysis
-        uses: ossf/scorecard-action@f49aabe0b5af0936a0987cfb85d86b75731b0186 # v2.4.1
+        uses: ossf/scorecard-action@05b42c624433fc40578a4040d5cf5e36ddca8cde # v2.4.2
         with:
           results_file: results.sarif
           results_format: sarif
@@ -59,6 +59,6 @@ jobs:
 
       # Upload the results to GitHub's code scanning dashboard.
       - name: Upload Scan Results
-        uses: github/codeql-action/upload-sarif@60168efe1c415ce0f5521ea06d5c2062adbeed1b # v3.28.17
+        uses: github/codeql-action/upload-sarif@ff0a06e83cb2de871e5a09832bc6a81e7276941f # v3.28.18
         with:
           sarif_file: results.sarif

CONTRIBUTING.md

@@ -375,14 +375,14 @@ To edit an existing article, you need to find the markdown file in the `site/pag
 
 The codebox component is used to display code snippets. If two code snippets follow without any text between them, they will be displayed in the same codebox, but with two tabs.
 
-```md
-'''cjs
+````md
+```cjs
 const http = require('node:http');
-'''
+```
 
-'''mjs
+```mjs
 import http from 'node:http';
-'''
 ```
+````
 
 `cjs` and `mjs` are variants of `js`, it's just to display the correct language in the codebox (cjs = CommonJS, mjs = ES Module).

apps/site/components/Link.tsx

@@ -7,7 +7,7 @@ const Link: FC<HTMLProps<HTMLAnchorElement>> = ({
   href,
   ...props
 }) => {
-  if (!href || href.toString().startsWith('http')) {
+  if (!href || /^https?:/.test(href.toString())) {
     return (
       <a href={href} {...props}>
         {children}