Skip to content

chore(actions): remove base job #7624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AugustinMauroy merged 3 commits into from
Apr 7, 2025
Merged

chore(actions): remove base job #7624

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
93045bb
chore(actions): remove `base` job
avivkeller Apr 5, 2025
236c046
code review 1
avivkeller Apr 5, 2025
ee55e06
use TURBO_FORCE
avivkeller Apr 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 6 additions & 24 deletions .github/workflows/lint-and-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,26 +28,11 @@ permissions:
# This permission is required by `MishaKav/jest-coverage-comment`
pull-requests: write

jobs:
base:
name: Base Tasks
runs-on: ubuntu-latest
outputs:
turbo_args: ${{ steps.turborepo_arguments.outputs.turbo_args }}

steps:
- name: Harden Runner
uses: step-security/harden-runner@4d991eb9b905ef189e4c376166672c3f2f230481 # v2.11.0
with:
egress-policy: audit
Comment thread
bmuenzenmeyer marked this conversation as resolved.

- name: Provide Turborepo Arguments
# This step is responsible for providing a reusable string that can be used within other steps and jobs
# that use the `turbo` cli command as a way of easily providing shared arguments to the `turbo` command
id: turborepo_arguments
# See https://turbo.build/repo/docs/reference/command-line-reference/run#--force
run: echo "turbo_args=--force=true" >> "$GITHUB_OUTPUT"
env:
# See https://turbo.build/repo/docs/reference/command-line-reference/run#--force
TURBO_ARGS: --force
Comment thread
avivkeller marked this conversation as resolved.
Outdated

jobs:
lint:
# This Job should run either on `merge_groups` or `push` events
# or `pull_request_target` event with a `labeled` action with a label named `github_actions:pull-request`
Expand All @@ -61,7 +46,6 @@ jobs:

name: Quality checks
runs-on: ubuntu-latest
needs: [base]

steps:
- name: Harden Runner
Expand Down Expand Up @@ -116,7 +100,7 @@ jobs:
github.event.pull_request.head.ref != 'chore/crowdin')
# We want to enforce that the actual `turbo@latest` package is used instead of a possible hijack from the user
# the `${{ needs.base.outputs.turbo_args }}` is a string substitution happening from the base job
Comment thread
avivkeller marked this conversation as resolved.
Outdated
run: npx --package=turbo@latest -- turbo lint check-types prettier ${{ needs.base.outputs.turbo_args }}
run: npx --package=turbo@latest -- turbo lint check-types prettier ${{ env.TURBO_ARGS }}

- name: Save Lint Cache
# We only want to save caches on `push` events or `pull_request_target` events
Expand Down Expand Up @@ -151,7 +135,6 @@ jobs:

name: Tests
runs-on: ubuntu-latest
needs: [base]

environment:
name: Storybook
Expand Down Expand Up @@ -188,8 +171,7 @@ jobs:
# We want to run Unit Tests in every circumstance, including Crowdin PRs and Dependabot PRs to ensure
# that changes to dependencies or translations don't break the Unit Tests
# We want to enforce that the actual `turbo@latest` package is used instead of a possible hijack from the user
# the `${{ needs.base.outputs.turbo_args }}` is a string substitution happening from the base job
run: npx --package=turbo@latest -- turbo test:unit ${{ needs.base.outputs.turbo_args }} -- --ci --coverage
run: npx --package=turbo@latest -- turbo test:unit ${{ env.TURBO_ARGS }} -- --ci --coverage

- name: Start Visual Regression Tests (Chromatic)
# This assigns the Environment Deployment for Storybook
Expand Down
Loading