Blog: add update to Security CI incident by RafaelGSS · Pull Request #7658 · nodejs/nodejs.org

RafaelGSS · 2025-04-17T16:04:42Z

cc: @nodejs/tsc

Co-Authored-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Co-Authored-By: Richard Lau <rlau@redhat.com> Co-Authored-By: Matteo Collina <matteo.collina@gmail.com>

vercel · 2025-04-17T16:04:47Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nodejs-org	✅ Ready (Inspect)	Visit Preview	Apr 23, 2025 2:26pm

avivkeller · 2025-04-17T16:14:15Z

FYI for Node.js Website Team (Unrelated to contents of this PR):
https://nodejs-org-git-security-incident-update-openjs.vercel.app/en/feed/vulnerability.xml shows #7648 in action

github-actions · 2025-04-17T19:21:23Z

Lighthouse Results

URL	Performance	Accessibility	Best Practices	SEO	Report
/en	🟢 99	🟢 100	🟢 100	🟢 91	🔗
/en/about	🟢 100	🟢 100	🟢 100	🟢 91	🔗
/en/about/previous-releases	🟢 99	🟢 100	🟢 100	🟢 92	🔗
/en/download	🟢 98	🟢 100	🟢 96	🟢 91	🔗
/en/blog	🟢 100	🟢 100	🟢 96	🟢 92	🔗

codecov-commenter · 2025-04-18T13:50:12Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@d9c0508). Learn more about missing BASE report.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7658   +/-   ##
=======================================
  Coverage        ?   74.61%           
=======================================
  Files           ?       96           
  Lines           ?     7689           
  Branches        ?      192           
=======================================
  Hits            ?     5737           
  Misses          ?     1950           
  Partials        ?        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

RafaelGSS · 2025-04-18T13:50:56Z

FYI, I might not be available next week. Feel free to merge this PR on Monday.

mcollina

I need to send some edit, will do asap.

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Signed-off-by: Matteo Collina <matteo.collina@gmail.com>

Signed-off-by: Matteo Collina <matteo.collina@gmail.com>

mhdawson

LGTM

mcollina · 2025-04-23T13:33:31Z

@nodejs/nodejs-website can someone help me sorting out the linting here? This is exactly like we want it.

mcollina

lgtm

Signed-off-by: Matteo Collina <matteo.collina@gmail.com>

avivkeller · 2025-04-23T13:55:22Z

@nodejs/nodejs-website can someone help me sorting out the linting here?

You need to run npm format.

This is exactly like we want it.

What does npm format do that isn't acceptable?

mcollina · 2025-04-23T14:12:15Z

@node-core/website:lint: @node-core/website:lint:md: cache hit, replaying logs c9d8947053a45b98
@node-core/website:lint: @node-core/website:lint:md:
@node-core/website:lint: @node-core/website:lint:md:
@node-core/website:lint: @node-core/website:lint:md: > lint:md
@node-core/website:lint: @node-core/website:lint:md: > eslint "**/*.md?(x)" --cache --cache-strategy=content --cache-location=.eslintmdcache
@node-core/website:lint: @node-core/website:lint:md:
@node-core/website:lint:
@node-core/website:lint: @node-core/website:lint:md: /Users/matteo/repos/nodejs.org/apps/site/pages/en/blog/vulnerability/march-2025-ci-incident.md
@node-core/website:lint: @node-core/website:lint:md:   70:1  warning  {"reason":"Unexpected duplicate toplevel heading, exected a single heading with rank `1`","source"@node-core/website:lint: no-multiple-toplevel-headings","severity":1}  mdx/remark
@node-core/website:lint: @node-core/website:lint:md:
@node-core/website:lint: @node-core/website:lint:md: ✖ 1 problem (0 errors, 1 warning)
@node-core/website:lint: @node-core/website:lint:md:   0 errors and 1 warning potentially fixable with the `--fix` option.
@node-core/website:lint: @node-core/website:lint:md:

Note that the content is correct.

avivkeller · 2025-04-23T14:18:14Z

Can you run prettier on the content? The ESLint issue is just a warning, and wouldn't fail the quality checks

Signed-off-by: Matteo Collina <hello@matteocollina.com>

mcollina

lgtm

Blog: add update to Security CI incident

97a9c96

Co-Authored-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Co-Authored-By: Richard Lau <rlau@redhat.com> Co-Authored-By: Matteo Collina <matteo.collina@gmail.com>

RafaelGSS requested a review from a team as a code owner April 17, 2025 16:04

vercel bot deployed to Preview April 17, 2025 16:05 View deployment

avivkeller reviewed Apr 17, 2025

View reviewed changes

Comment thread apps/site/pages/en/blog/vulnerability/march-2025-ci-incident.md Outdated

avivkeller reviewed Apr 17, 2025

View reviewed changes

Comment thread apps/site/pages/en/blog/vulnerability/march-2025-ci-incident.md Outdated

avivkeller reviewed Apr 17, 2025

View reviewed changes

Comment thread apps/site/pages/en/blog/vulnerability/march-2025-ci-incident.md Outdated

anonrig approved these changes Apr 17, 2025

View reviewed changes

UlisesGascon approved these changes Apr 17, 2025

View reviewed changes

bjohansebas approved these changes Apr 17, 2025

View reviewed changes

ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Apr 17, 2025

ovflowd deployed to Storybook April 17, 2025 19:20 — with GitHub Actions View deployment

github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Apr 17, 2025

aduh95 reviewed Apr 17, 2025

View reviewed changes

Comment thread apps/site/pages/en/blog/vulnerability/march-2025-ci-incident.md Outdated

aduh95 reviewed Apr 17, 2025

View reviewed changes

Comment thread apps/site/pages/en/blog/vulnerability/march-2025-ci-incident.md Outdated

mcollina reviewed Apr 18, 2025

View reviewed changes

Comment thread apps/site/pages/en/blog/vulnerability/march-2025-ci-incident.md

RafaelGSS added 2 commits April 18, 2025 10:48

fixup! Blog: add update to Security CI incident

9ad38a2

fixup! fixup! Blog: add update to Security CI incident

2d74437

vercel bot deployed to Preview April 18, 2025 13:50 View deployment

avivkeller approved these changes Apr 18, 2025

View reviewed changes

vercel bot deployed to Preview April 18, 2025 13:51 View deployment

avivkeller added the github_actions:pull-request Trigger Pull Request Checks label Apr 18, 2025

avivkeller deployed to Storybook April 18, 2025 13:53 — with GitHub Actions View deployment

github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Apr 18, 2025

mcollina requested changes Apr 18, 2025

View reviewed changes

aduh95 reviewed Apr 22, 2025

View reviewed changes

Comment thread apps/site/pages/en/blog/vulnerability/march-2025-ci-incident.md Outdated

Update apps/site/pages/en/blog/vulnerability/march-2025-ci-incident.md

10547a9

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Signed-off-by: Matteo Collina <matteo.collina@gmail.com>

vercel bot deployed to Preview April 22, 2025 10:21 View deployment

aduh95 reviewed Apr 22, 2025

View reviewed changes

Comment thread apps/site/pages/en/blog/vulnerability/march-2025-ci-incident.md Outdated

Update apps/site/pages/en/blog/vulnerability/march-2025-ci-incident.md

6375469

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Signed-off-by: Matteo Collina <matteo.collina@gmail.com>

vercel bot deployed to Preview April 22, 2025 14:19 View deployment

Update apps/site/pages/en/blog/vulnerability/march-2025-ci-incident.md

1112eb4

Signed-off-by: Matteo Collina <matteo.collina@gmail.com>

vercel bot deployed to Preview April 22, 2025 19:44 View deployment

mhdawson approved these changes Apr 22, 2025

View reviewed changes

aymen94 approved these changes Apr 23, 2025

View reviewed changes

mcollina approved these changes Apr 23, 2025

View reviewed changes

mcollina reviewed Apr 23, 2025

View reviewed changes

Comment thread apps/site/pages/en/blog/vulnerability/march-2025-ci-incident.md Outdated

Update apps/site/pages/en/blog/vulnerability/march-2025-ci-incident.md

2348bca

Signed-off-by: Matteo Collina <matteo.collina@gmail.com>

mcollina reviewed Apr 23, 2025

View reviewed changes

Comment thread apps/site/pages/en/blog/vulnerability/march-2025-ci-incident.md Outdated

Update apps/site/pages/en/blog/vulnerability/march-2025-ci-incident.md

336e39d

Signed-off-by: Matteo Collina <matteo.collina@gmail.com>

vercel bot deployed to Preview April 23, 2025 13:53 View deployment

fixup

4ba20de

Signed-off-by: Matteo Collina <hello@matteocollina.com>

vercel bot deployed to Preview April 23, 2025 14:26 View deployment

mcollina approved these changes Apr 23, 2025

View reviewed changes

avivkeller added the github_actions:pull-request Trigger Pull Request Checks label Apr 23, 2025

avivkeller deployed to Storybook April 23, 2025 14:43 — with GitHub Actions View deployment

github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Apr 23, 2025

aduh95 added this pull request to the merge queue Apr 23, 2025

Merged via the queue into main with commit 0b24039 Apr 23, 2025
16 checks passed

aduh95 deleted the security-incident-update branch April 23, 2025 15:31

Conversation

RafaelGSS commented Apr 17, 2025

Uh oh!

vercel bot commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

avivkeller commented Apr 17, 2025

Uh oh!

github-actions bot commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented Apr 18, 2025 • edited by codecov bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

RafaelGSS commented Apr 18, 2025

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mhdawson left a comment

Choose a reason for hiding this comment

Uh oh!

mcollina commented Apr 23, 2025

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

avivkeller commented Apr 23, 2025

Uh oh!

mcollina commented Apr 23, 2025

Uh oh!

avivkeller commented Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

vercel bot commented Apr 17, 2025 •

edited

Loading

github-actions bot commented Apr 17, 2025 •

edited

Loading

codecov-commenter commented Apr 18, 2025 •

edited by codecov bot

Loading

avivkeller commented Apr 23, 2025 •

edited

Loading