Skip to content

blog: add post-eol announcement#7838

Merged
ovflowd merged 8 commits into
mainfrom
add-post-eol-blog
Jun 6, 2025
Merged

blog: add post-eol announcement#7838
ovflowd merged 8 commits into
mainfrom
add-post-eol-blog

Conversation

@mcollina

@mcollina mcollina commented Jun 5, 2025

Copy link
Copy Markdown
Member

Ref #7773 - this is my blog post proposal.

Thanks to @rginn and @kyliewd for the edits.

Signed-off-by: Matteo Collina <hello@matteocollina.com>
Copilot AI review requested due to automatic review settings June 5, 2025 11:07
@mcollina mcollina requested a review from a team as a code owner June 5, 2025 11:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@vercel

vercel Bot commented Jun 5, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 6, 2025 9:29pm

@codecov

codecov Bot commented Jun 5, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.44%. Comparing base (2054bcc) to head (91ccb75).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7838      +/-   ##
==========================================
- Coverage   75.49%   75.44%   -0.05%     
==========================================
  Files         101      101              
  Lines        8309     8305       -4     
  Branches      218      218              
==========================================
- Hits         6273     6266       -7     
- Misses       2034     2037       +3     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Claudio W. <cwunder@gnome.org>

@ovflowd ovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this! TSYM, Matteo!

@AugustinMauroy AugustinMauroy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO images should be static file. like the rest of blog posts

Comment thread apps/site/pages/en/blog/announcements/node-18-eol-support.md Outdated
Comment thread apps/site/pages/en/blog/announcements/node-18-eol-support.md Outdated
Comment thread apps/site/pages/en/blog/announcements/node-18-eol-support.md Outdated
Comment thread apps/site/pages/en/blog/announcements/node-18-eol-support.md Outdated
Comment thread apps/site/pages/en/blog/announcements/node-18-eol-support.md
Co-authored-by: Aviv Keller <me@aviv.sh>
Signed-off-by: Matteo Collina <matteo.collina@gmail.com>
Co-authored-by: Aviv Keller <me@aviv.sh>
Signed-off-by: Matteo Collina <matteo.collina@gmail.com>
@avivkeller

avivkeller commented Jun 5, 2025

Copy link
Copy Markdown
Member

@mcollina it seems my suggestion broke deployments 😅, can you wrap it in quotes ("" / '')?

Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina

mcollina commented Jun 5, 2025

Copy link
Copy Markdown
Member Author

I think I fixed it

Signed-off-by: Matteo Collina <hello@matteocollina.com>

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AugustinMauroy AugustinMauroy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread apps/site/pages/en/blog/announcements/node-18-eol-support.md Outdated
Co-authored-by: Sebastian Beltran <bjohansebas@gmail.com>
Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Jun 6, 2025
@ovflowd ovflowd enabled auto-merge June 6, 2025 21:07
@github-actions github-actions Bot removed the github_actions:pull-request Trigger Pull Request Checks label Jun 6, 2025
@github-actions

github-actions Bot commented Jun 6, 2025

Copy link
Copy Markdown
Contributor

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟠 82 🔗
/en/about/previous-releases 🟢 97 🟢 100 🟢 100 🟠 83 🔗
/en/download 🟢 97 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

Signed-off-by: Claudio W. <cwunder@gnome.org>
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Jun 6, 2025
@github-actions github-actions Bot removed the github_actions:pull-request Trigger Pull Request Checks label Jun 6, 2025
@ovflowd ovflowd added this pull request to the merge queue Jun 6, 2025
Merged via the queue into main with commit 639bf95 Jun 6, 2025
15 checks passed
@ovflowd ovflowd deleted the add-post-eol-blog branch June 6, 2025 21:36
@mcollina

mcollina commented Jun 8, 2025

Copy link
Copy Markdown
Member Author

@ovflowd this should not have landed. It was clearly noted for a date in the future.

@mcollina

mcollina commented Jun 8, 2025

Copy link
Copy Markdown
Member Author

Also, images are not rendering

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.