Skip to content

fix(table): only apply border to immediate td children #7911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ovflowd merged 3 commits into from
Jul 1, 2025
Merged

fix(table): only apply border to immediate td children #7911

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ee54cc
fix(table): only apply border to immediate `td` children
avivkeller Jun 30, 2025
d6c28a8
story
avivkeller Jul 1, 2025
9f6445d
use old name
avivkeller Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 23 additions & 19 deletions packages/ui-components/__design__/table.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const tableData = [
['Data 1', 'Data 2', 'Data 3'],
];

export const Table: StoryObj = {
export const TableWithSubTableRow: StoryObj = {
render: () => (
<main>
<table>
Expand All @@ -25,24 +25,28 @@ export const Table: StoryObj = {
))}
</tr>
))}
</tbody>
</table>
</main>
),
};

export const HeadlessTable: StoryObj = {
render: () => (
<main>
<table>
<tbody>
{tableData.map((row, rowIndex) => (
<tr key={rowIndex}>
{row.map((cell, cellIndex) => (
<td key={cellIndex}>{cell}</td>
))}
</tr>
))}
<tr>
<td colSpan={3}>
<table>
<thead>
<tr>
<th>Sub 1</th>
<th>Sub 2</th>
</tr>
</thead>
<tbody>
<tr>
<td>Sub A</td>
<td>Sub B</td>
</tr>
<tr>
<td>Sub C</td>
<td>Sub D</td>
</tr>
</tbody>
</table>
</td>
</tr>
</tbody>
</table>
</main>
Expand Down
2 changes: 1 addition & 1 deletion packages/ui-components/styles/markdown.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ main {
@apply font-semibold;
}

tr:last-child td {
tr:last-child > td {
@apply sm:border-b-0;

&:last-child {
Expand Down
Loading