-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix(ui): Sidebar scroll not showing last element #8563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 6 commits
Commits
Show all changes
70 commits
Select commit
Hold shift + click to select a range
6289850
fix(ui): Sidebar scroll not showing last element
malav2110 e7054d2
fix(ui): correct sidebar sticky positioning for better visibility
malav2110 8bb2784
Merge branch 'nodejs:main' into fix-sidebar-scroll-last-item
malav2110 8494756
fix: update ui-package version to 1.5.9 in package.json
malav2110 d84fcd3
fix(ui): adjust sidebar styles for improved layout and scrolling beha…
malav2110 5502c79
Merge branch 'nodejs:main' into fix-sidebar-scroll-last-item
malav2110 30322b4
Merge branch 'nodejs:main' into fix-sidebar-scroll-last-item
malav2110 c4bc38a
fix(ui): refine sidebar styles for improved item spacing and layout
malav2110 04b5378
Merge remote-tracking branch 'upstream/main' into fix-sidebar-scroll-…
malav2110 97bc5a2
fix: use fetchWithRetry for nodevu fetch calls (#8609)
MattIPv4 b3b5f3c
meta: bump wrangler from 4.54.0 to 4.59.1 (#8592)
dependabot[bot] a0bb262
meta: bump the storybook group with 3 updates (#8601)
dependabot[bot] d6a59d8
meta: bump the mdx group with 6 updates (#8599)
dependabot[bot] 1843766
[automated]: crowdin sync (#8557)
nodejs-crowdin 25240c4
meta: bump @playwright/test from 1.57.0 to 1.58.1 (#8604)
dependabot[bot] 674065e
meta: bump the lint group with 5 updates (#8598)
dependabot[bot] d22beb5
meta: bump wrangler from 4.54.0 to 4.61.1 (#8605)
dependabot[bot] da9938e
meta: bump the vercel group with 9 updates (#8603)
dependabot[bot] b431ea4
hotfix: fetch retry fix (#8615)
ovflowd e268864
feat(blog): create post for v24.13.1 (#8616)
github-actions[bot] 3dc88de
feat(blog): create post for v25.6.1 (#8617)
github-actions[bot] c3adf17
chore: adjust ui-components publishing (#8620)
ovflowd 6b7afd2
feat: conditional exports, numerous bug fixes and ux improvements (#8…
ovflowd 1bd01c4
meta: bump rehype-shiki (#8625)
ovflowd 043918c
meta: bump the react group with 3 updates (#8600)
dependabot[bot] 1451141
fix: add missing ESM/CJS tabs with their examples in Learn section (#…
nitin-is-me 8b5871b
feat(i18n): enable ta translation (#8622)
naveenkarmegam 9798af7
fix: fixed statically indexed path for turbopack (#8633)
ovflowd ce04583
feat: supporters improvements (#8627)
araujogui 173a006
feat: max width footer & navbar (#8629)
ovflowd c532611
[automated]: crowdin sync (#8624)
nodejs-crowdin e701e6a
meta: export types for rehype-shiki (#8632)
ovflowd 8bef389
meta: bump the testing group across 1 directory with 4 updates (#8614)
dependabot[bot] 1e2a804
Blog: update new HackerOne signal requirements (#8641)
RafaelGSS 85ee3a2
fix(BasePagination): fix pagination list item vertical alignment (863…
mertssmnoglu 03d8a20
meta: bump nvm to v0.40.4 (#8643)
ljharb f25489c
feat(blog): create post for v24.14.0 (#8656)
github-actions[bot] 6a331c6
feat(blog): create post for v25.7.0 (#8657)
github-actions[bot] 063f4cc
fix: correct platform dropdown aria label key (#8654)
adityagiri3600 9c7749b
meta: bump step-security/harden-runner from 2.14.1 to 2.14.2 (#8651)
dependabot[bot] b23ad83
meta: bump crowdin/github-action from 2.14.0 to 2.14.1 (#8652)
dependabot[bot] d4a295c
meta: bump chromaui/action from 13.3.5 to 15.1.1 (#8653)
dependabot[bot] d8e45dc
Blog: New HackerOne Signal Requirement for reports (#8658)
RafaelGSS edc355f
[automated]: crowdin sync (#8642)
nodejs-crowdin 4f16502
meta: bump storybook from 10.2.6 to 10.2.10 (#8662)
dependabot[bot] 1c769c7
feat: add system theme toggle (#8659)
araujogui d7461a5
chore: add blog exclude explain comment (#8661)
araujogui b85ee14
fix(deps): make ts prod (#8671)
avivkeller 74ce343
[automated]: crowdin sync (#8663)
nodejs-crowdin c8caf5e
feat(ui-components): add Signature and FunctionSignature components (…
canerakdas 7f76782
blog: clarify contact method for low signal researchers (#8613)
UlisesGascon 13e7268
chore(remark-lint): better invalid type regex (#8673)
avivkeller cbd1006
meta: bump actions/upload-artifact from 6.0.0 to 7.0.0 (#8674)
dependabot[bot] 8080caa
meta: bump @tailwindcss/postcss from 4.1.18 to 4.2.1 in the styling g…
dependabot[bot] 718496b
meta: bump jsdom from 28.0.0 to 28.1.0 in the testing group (#8684)
dependabot[bot] 00417e8
meta: bump the vercel group with 6 updates (#8685)
dependabot[bot] ca1c61c
meta: bump nock from 14.0.10 to 14.0.11 (#8686)
dependabot[bot] 8f6109a
meta: bump globals from 16.5.0 to 17.3.0 (#8688)
dependabot[bot] a77341c
meta: bump the mdx group with 5 updates (#8680)
dependabot[bot] f882ffa
meta: bump chromaui/action from 15.1.1 to 15.2.0 (#8678)
dependabot[bot] 71fbe9e
meta: bump actions/download-artifact from 7.0.0 to 8.0.0 (#8677)
dependabot[bot] a0083b9
meta: bump crowdin/github-action from 2.14.1 to 2.15.0 (#8676)
dependabot[bot] d292987
meta: bump step-security/harden-runner from 2.14.2 to 2.15.0 (#8675)
dependabot[bot] c2af20e
feat(blog): create post for v25.8.0 (#8692)
github-actions[bot] 24db582
meta: bump @orama/core from 1.2.16 to 1.2.19 in the orama group (#8681)
dependabot[bot] b9868df
meta: bump the storybook group with 3 updates (#8682)
dependabot[bot] ef05583
fix(ui): Sidebar scroll not showing last element
malav2110 895b3e7
fix(ui): adjust sidebar styles for improved layout and scrolling beha…
malav2110 83529b2
fix(ui): refine sidebar styles for improved item spacing and layout
malav2110 2a036eb
fix(package): bump version to 1.6.2
malav2110 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,6 +12,7 @@ | |
| py-6 | ||
| sm:overflow-auto | ||
| sm:border-r | ||
| sm:pb-16 | ||
| md:max-w-xs | ||
| lg:px-6 | ||
| dark:border-neutral-900 | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Padding could probably be a bit smaller.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With
pb-14, the last item on the list is barely visible thus addedpb-16.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that really the case? This is how much padding I see
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're probably referring to the padding when the footer isn't visible.
So this is probably not the place you want to change the padding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For example, if you see the beginning of the sidebar has the same margins/paddings no matter if the header is visible or not
But the same isn't truthy for the end of the sidebar:
So this means this place is probably not the right one to add padding. Or it must be a mix of two different places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I would recommend to avoid making assumptions, if I tell you it is possible or something the contrary, then I'm pretty sure it is possible 😛)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I just want to avoid giving you a solution plated, so you can try it yourself 👀)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Thanks for the examples and for calling that out. That helps reset my assumptions.
Appreciate you pushing me to think it through rather than handing me the solution 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely! Although, I know I used a bit of a strong tone, apologies for that. Let me know if you get stuck and need support tho 🙇
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, appreciate that 🙂
I pushed a fix with reduced padding to address the issue that started the thread, and also resolved the merge conflict. Curious to hear your thoughts.