Skip to content

chore: prop adjustment for single character Badges #8564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ovflowd merged 1 commit into from
Jan 27, 2026
Merged

chore: prop adjustment for single character Badges #8564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
chore: follow up pr for #8561
  • Loading branch information
@canerakdas
canerakdas committed Jan 26, 2026
commit 3f27d39f7fded9a080a1ce31c8680287598f1fa1
2 changes: 1 addition & 1 deletion packages/ui-components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@node-core/ui-components",
"version": "1.5.7",
"version": "1.5.8",
"type": "module",
"exports": {
"./*": [
Expand Down
2 changes: 0 additions & 2 deletions packages/ui-components/src/Common/Badge/index.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ export const Medium: Story = {

export const Circular: Story = {
args: {
circular: true,
children: 'D',
size: 'small',
kind: 'error',
Expand All @@ -58,7 +57,6 @@ export const Circular: Story = {

export const MediumCircular: Story = {
args: {
circular: true,
children: 'E',
kind: 'warning',
},
Expand Down
7 changes: 4 additions & 3 deletions packages/ui-components/src/Common/Badge/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,11 @@ type BadgeSize = 'small' | 'medium';
type BadgeProps = HTMLAttributes<HTMLSpanElement> & {
size?: BadgeSize;
kind?: BadgeKind;
circular?: boolean;
};

const Badge: FC<PropsWithChildren<BadgeProps>> = ({
kind = 'default',
size = 'medium',
circular = false,
className,
children,
...props
Expand All @@ -26,7 +24,10 @@ const Badge: FC<PropsWithChildren<BadgeProps>> = ({
styles.badge,
styles[kind],
styles[size],
{ [styles.circular]: circular },
{
[styles.circular]:
typeof children === 'string' && children.length === 1,
},
className
)}
{...props}
Expand Down
Loading