undici/test/sync-error-in-callback.js at 07eeeb86e73ce038af8cd0b46dc33adf2ad697c3 · nodejs/undici · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
'use strict'

const { tspl } = require('@matteo.collina/tspl')
const { test, after } = require('node:test')
const { Client } = require('..')
const { createServer } = require('node:http')

test('synchronous error in request callback should reach uncaughtException handler', async (t) => {
  const p = tspl(t, { plan: 3 })

  const server = createServer((req, res) => {
    res.end('hello')
  })
  after(() => server.close())

  await new Promise((resolve) => {
    server.listen(0, resolve)
  })

  const client = new Client(`http://localhost:${server.address().port}`)
  after(() => client.close())

  const testError = new Error('sync error in callback')

  // Set up uncaughtException handler
  const originalHandler = process.listenerCount('uncaughtException') > 0
    ? process.listeners('uncaughtException')[0]
    : null

  process.removeAllListeners('uncaughtException')

  const uncaughtHandler = (err) => {
    p.strictEqual(err, testError, 'Error should reach uncaughtException handler')
    // Clean up
    process.removeListener('uncaughtException', uncaughtHandler)
    if (originalHandler) {
      process.on('uncaughtException', originalHandler)
    }
  }

  process.on('uncaughtException', uncaughtHandler)

  client.request({
    path: '/',
    method: 'GET'
  }, (err, data) => {
    p.ifError(err)
    p.strictEqual(data.statusCode, 200)

    // Destroy the stream to simulate the described scenario
    data.body.destroy()

    // This synchronous error should reach the uncaughtException handler
    throw testError
  })

  // Wait a bit to ensure the uncaughtException handler is triggered
  await new Promise(resolve => setTimeout(resolve, 100))

  // Clean up handler if not triggered
  process.removeListener('uncaughtException', uncaughtHandler)
  if (originalHandler) {
    process.on('uncaughtException', originalHandler)
  }

  await p.completed
})

test('synchronous error thrown immediately in request callback', async (t) => {
  const p = tspl(t, { plan: 3 })

  const server = createServer((req, res) => {
    res.end('hello')
  })
  after(() => server.close())

  await new Promise((resolve) => {
    server.listen(0, resolve)
  })

  const client = new Client(`http://localhost:${server.address().port}`)
  after(() => client.close())

  const testError = new Error('immediate sync error')

  // Set up uncaughtException handler
  const originalHandler = process.listenerCount('uncaughtException') > 0
    ? process.listeners('uncaughtException')[0]
    : null

  process.removeAllListeners('uncaughtException')

  const uncaughtHandler = (err) => {
    p.strictEqual(err, testError, 'Error should reach uncaughtException handler')
    // Clean up
    process.removeListener('uncaughtException', uncaughtHandler)
    if (originalHandler) {
      process.on('uncaughtException', originalHandler)
    }
  }

  process.on('uncaughtException', uncaughtHandler)

  client.request({
    path: '/',
    method: 'GET'
  }, (err, data) => {
    p.ifError(err)
    p.strictEqual(data.statusCode, 200)

    // Throw immediately without any stream operations
    throw testError
  })

  // Wait a bit to ensure the uncaughtException handler is triggered
  await new Promise(resolve => setTimeout(resolve, 100))

  // Clean up handler if not triggered
  process.removeListener('uncaughtException', uncaughtHandler)
  if (originalHandler) {
    process.on('uncaughtException', originalHandler)
  }

  await p.completed
})

test('synchronous error in request callback with error parameter', async (t) => {
  const p = tspl(t, { plan: 1 })

  const server = createServer((req, res) => {
    // Force an error by destroying the socket
    req.socket.destroy()
  })
  after(() => server.close())

  server.listen(0, () => {
    const client = new Client(`http://localhost:${server.address().port}`)
    after(() => client.close())

    client.request({
      path: '/',
      method: 'GET'
    }, (err, data) => {
      // We expect an error from the destroyed socket
      p.ok(err)

      // Don't throw here as it would interfere with test completion
      // The important tests are the ones where we get successful responses
    })
  })

  await p.completed
})