Skip to content

Commit 2fb132c

Browse files
authored
fix(test): make issue-2898-comment.js assertion robust against flakiness (#5208)
1 parent 584e6ae commit 2fb132c

1 file changed

Lines changed: 10 additions & 4 deletions

File tree

test/fetch/issue-2898-comment.js

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@ const { test } = require('node:test')
66
const { Agent, Request, fetch } = require('../..')
77

88
test('issue #2828, RequestInit dispatcher options overrides Request input dispatcher', async (t) => {
9-
t.plan(2)
10-
119
class CustomAgentA extends Agent {
1210
dispatch (options, handler) {
1311
options.headers['x-my-header-a'] = 'hello'
@@ -23,19 +21,27 @@ test('issue #2828, RequestInit dispatcher options overrides Request input dispat
2321
}
2422

2523
const server = createServer({ joinDuplicateHeaders: true }, (req, res) => {
26-
t.assert.strictEqual(req.headers['x-my-header-a'], undefined)
27-
t.assert.strictEqual(req.headers['x-my-header-b'], 'world')
2824
res.end()
2925
}).listen(0)
3026

3127
t.after(server.close.bind(server))
3228
await once(server, 'listening')
3329

30+
const receivedHeaders = new Promise((resolve) => {
31+
server.on('request', (req) => {
32+
resolve(req.headers)
33+
})
34+
})
35+
3436
const request = new Request(`http://localhost:${server.address().port}`, {
3537
dispatcher: new CustomAgentA()
3638
})
3739

3840
await fetch(request, {
3941
dispatcher: new CustomAgentB()
4042
})
43+
44+
const headers = await receivedHeaders
45+
t.assert.strictEqual(headers['x-my-header-a'], undefined)
46+
t.assert.strictEqual(headers['x-my-header-b'], 'world')
4147
})

0 commit comments

Comments
 (0)