Skip to content

Commit 9c12e26

Browse files
authored
chore(http2): collapse duplicate request stream setup (#5140)
1 parent 098b2d9 commit 9c12e26

1 file changed

Lines changed: 8 additions & 16 deletions

File tree

lib/dispatcher/client-h2.js

Lines changed: 8 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -866,26 +866,18 @@ function writeH2 (client, request) {
866866

867867
// TODO(metcoder95): add support for sending trailers
868868
const shouldEndStream = body === null
869+
869870
if (expectContinue) {
870871
headers[HTTP2_HEADER_EXPECT] = '100-continue'
871-
stream = requestStream(headers, { endStream: shouldEndStream, signal })
872-
if (stream == null) {
873-
return false
874-
}
875-
stream[kHTTP2Stream] = true
876-
bindRequestToStream(request, stream, null)
877-
} else {
878-
stream = requestStream(headers, {
879-
endStream: shouldEndStream,
880-
signal
881-
})
882-
if (stream == null) {
883-
return false
884-
}
885-
stream[kHTTP2Stream] = true
886-
bindRequestToStream(request, stream, null)
887872
}
888873

874+
stream = requestStream(headers, { endStream: shouldEndStream, signal })
875+
if (stream == null) {
876+
return false
877+
}
878+
stream[kHTTP2Stream] = true
879+
bindRequestToStream(request, stream, null)
880+
889881
// Increment counter as we have new streams open
890882
++session[kOpenStreams]
891883
stream.setTimeout(requestTimeout)

0 commit comments

Comments
 (0)