Skip to content

Commit d2bb04e

Browse files
authored
test (pool.js): fix flakyness of clientTtl test (#4494)
1 parent 65e097f commit d2bb04e

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

test/pool.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -579,11 +579,9 @@ test('pool connect', async (t) => {
579579
})
580580

581581
test('pool connect with clientTtl specified', async (t) => {
582-
t = tspl(t, { plan: 1 })
582+
t = tspl(t, { plan: 3 })
583583

584-
const server = createServer({ joinDuplicateHeaders: true }, (c) => {
585-
t.fail()
586-
})
584+
const server = createServer({ joinDuplicateHeaders: true }, t.fail)
587585
server.on('connect', (req, socket, firstBodyChunk) => {
588586
socket.write('HTTP/1.1 200 Connection established\r\n\r\n')
589587

@@ -607,7 +605,7 @@ test('pool connect with clientTtl specified', async (t) => {
607605
path: '/'
608606
})
609607

610-
t.strictEqual(socket.closed, false)
608+
t.strictEqual(socket.closed, false, 'client not closed yet')
611609

612610
let recvData = ''
613611
socket.on('data', (d) => {
@@ -619,10 +617,12 @@ test('pool connect with clientTtl specified', async (t) => {
619617
})
620618

621619
socket.write('Body')
622-
socket.end()
620+
await new Promise((resolve, reject) => socket.end((e) => e ? reject(e) : resolve()))
621+
622+
t.strictEqual(socket.closed, false, 'client not closed yet')
623623

624624
await new Promise(resolve => setTimeout(resolve, 10))
625-
t.strictEqual(socket.closed, true)
625+
t.strictEqual(socket.closed, true, 'client closed after ttl')
626626
})
627627

628628
await t.completed

0 commit comments

Comments
 (0)