Skip to content

Commit f4cc9a5

Browse files
committed
fix remarks
1 parent 33f7fb4 commit f4cc9a5

1 file changed

Lines changed: 2 additions & 9 deletions

File tree

test/fetch/cookies.js

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ const { stringify: qsStringify } = require('node:querystring')
88
const { Client, fetch, Headers } = require('../..')
99
const pem = require('@metcoder95/https-pem')
1010
const { createSecureServer } = require('node:http2')
11-
const { createDeferredPromise } = require('../../lib/util/promise')
1211

1312
describe('cookies', () => {
1413
let server
@@ -73,7 +72,6 @@ describe('cookies', () => {
7372
})
7473

7574
test('Can receive set-cookie headers from a http2 server using fetch - issue #2885', async () => {
76-
const donePromise = createDeferredPromise()
7775
const server = createSecureServer(pem)
7876
server.on('stream', (stream, headers) => {
7977
stream.respond({
@@ -84,7 +82,6 @@ describe('cookies', () => {
8482
})
8583

8684
stream.end('test')
87-
donePromise.resolve()
8885
})
8986

9087
await once(server.listen(0), 'listening')
@@ -96,11 +93,6 @@ describe('cookies', () => {
9693
allowH2: true
9794
})
9895

99-
after(async () => {
100-
await client.close()
101-
await new Promise((resolve, reject) => server.close(err => err ? reject(err) : resolve()))
102-
})
103-
10496
const response = await fetch(
10597
`https://localhost:${server.address().port}/`,
10698
// Needs to be passed to disable the reject unauthorized
@@ -116,6 +108,7 @@ describe('cookies', () => {
116108
deepStrictEqual(response.headers.getSetCookie(), ['Space=Cat; Secure; HttpOnly'])
117109
strictEqual(await response.text(), 'test')
118110

119-
await donePromise.promise
111+
await client.close()
112+
await new Promise((resolve, reject) => server.close(err => err ? reject(err) : resolve()))
120113
})
121114
})

0 commit comments

Comments
 (0)