From 0b75cf018af432c3d3fceb0f97a58057e243a209 Mon Sep 17 00:00:00 2001 From: tsctx <91457664+tsctx@users.noreply.github.com> Date: Sun, 11 May 2025 13:53:52 +0000 Subject: [PATCH 1/3] add node v24 workflow --- .github/workflows/nodejs-shared.yml | 2 +- .github/workflows/nodejs.yml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/nodejs-shared.yml b/.github/workflows/nodejs-shared.yml index 172cc72df80..3126633343b 100644 --- a/.github/workflows/nodejs-shared.yml +++ b/.github/workflows/nodejs-shared.yml @@ -19,7 +19,7 @@ jobs: fail-fast: false max-parallel: 0 matrix: - version: [20, 22, 23] + version: [20, 22, 24] runs-on: ubuntu-latest timeout-minutes: 120 steps: diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 2f6973ccfa3..da33b9e6c64 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -58,7 +58,7 @@ jobs: node-version: - 20 - 22 - - 23 + - 24 runs-on: - ubuntu-latest - windows-latest @@ -75,7 +75,7 @@ jobs: fail-fast: false max-parallel: 0 matrix: - version: [20, 22, 23] + version: [20, 22, 24] runs-on: ubuntu-latest timeout-minutes: 120 steps: From 39b9cd12f25c18a1099b0dc2f6eb987f8322138f Mon Sep 17 00:00:00 2001 From: tsctx <91457664+tsctx@users.noreply.github.com> Date: Tue, 13 May 2025 02:29:52 +0000 Subject: [PATCH 2/3] fix http2 test --- test/http2.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/test/http2.js b/test/http2.js index a370af1b60f..9b317e15b83 100644 --- a/test/http2.js +++ b/test/http2.js @@ -1527,7 +1527,7 @@ test('#3046 - GOAWAY Frame', async t => { t.strictEqual(response.headers['x-custom-h2'], 'hello') t.strictEqual(response.statusCode, 200) - t.rejects(response.body.text(), { + await t.rejects(response.body.text(), { message: 'HTTP/2: "GOAWAY" frame received with code 0', code: 'UND_ERR_SOCKET' }) @@ -1748,9 +1748,11 @@ test('Should handle http2 stream timeout', async t => { body: stream }) - t.rejects(res.body.text(), { + await t.rejects(res.body.text(), { message: 'HTTP/2: "stream timeout after 50"' }) + + await t.completed }) test('Should handle http2 trailers', async t => { From 241b930de3f0ab73cf59e6acf582411ba2cb4c98 Mon Sep 17 00:00:00 2001 From: tsctx <91457664+tsctx@users.noreply.github.com> Date: Tue, 13 May 2025 02:53:41 +0000 Subject: [PATCH 3/3] update wpt status --- test/wpt/status/fetch.status.json | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/test/wpt/status/fetch.status.json b/test/wpt/status/fetch.status.json index 07040863968..2557207bc88 100644 --- a/test/wpt/status/fetch.status.json +++ b/test/wpt/status/fetch.status.json @@ -57,11 +57,14 @@ "skip": true }, "request-headers.any.js": { + "note": "Float16Array is valid from node v24.", "fail": [ "Fetch with Chicken", "Fetch with Chicken with body", "Fetch with TacO and mode \"same-origin\" needs an Origin header", - "Fetch with TacO and mode \"cors\" needs an Origin header", + "Fetch with TacO and mode \"cors\" needs an Origin header" + ], + "flaky": [ "Fetch with POST with Float16Array body" ] }, @@ -70,8 +73,8 @@ "skip": true }, "request-upload.any.js": { - "note": "no Float16Array", - "fail": [ + "note": "Float16Array is valid from node v24.", + "flaky": [ "Fetch with POST with Float16Array body" ] },