Skip to content

add node v24 workflow #4206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcollina merged 3 commits into from
May 13, 2025
Merged

add node v24 workflow #4206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b75cf0
add node v24 workflow
tsctx May 11, 2025
39b9cd1
fix http2 test
tsctx May 13, 2025
241b930
update wpt status
tsctx May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/nodejs-shared.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
fail-fast: false
max-parallel: 0
matrix:
version: [20, 22, 23]
version: [20, 22, 24]
runs-on: ubuntu-latest
timeout-minutes: 120
steps:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
node-version:
- 20
- 22
- 23
- 24
runs-on:
- ubuntu-latest
- windows-latest
Expand All @@ -75,7 +75,7 @@ jobs:
fail-fast: false
max-parallel: 0
matrix:
version: [20, 22, 23]
version: [20, 22, 24]
runs-on: ubuntu-latest
timeout-minutes: 120
steps:
Expand Down
6 changes: 4 additions & 2 deletions test/http2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1527,7 +1527,7 @@ test('#3046 - GOAWAY Frame', async t => {
t.strictEqual(response.headers['x-custom-h2'], 'hello')
t.strictEqual(response.statusCode, 200)

t.rejects(response.body.text(), {
await t.rejects(response.body.text(), {
message: 'HTTP/2: "GOAWAY" frame received with code 0',
code: 'UND_ERR_SOCKET'
})
Expand Down Expand Up @@ -1748,9 +1748,11 @@ test('Should handle http2 stream timeout', async t => {
body: stream
})

t.rejects(res.body.text(), {
await t.rejects(res.body.text(), {
message: 'HTTP/2: "stream timeout after 50"'
})

await t.completed
})

test('Should handle http2 trailers', async t => {
Expand Down
9 changes: 6 additions & 3 deletions test/wpt/status/fetch.status.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,14 @@
"skip": true
},
"request-headers.any.js": {
"note": "Float16Array is valid from node v24.",
"fail": [
"Fetch with Chicken",
"Fetch with Chicken with body",
"Fetch with TacO and mode \"same-origin\" needs an Origin header",
"Fetch with TacO and mode \"cors\" needs an Origin header",
"Fetch with TacO and mode \"cors\" needs an Origin header"
],
"flaky": [
"Fetch with POST with Float16Array body"
]
},
Expand All @@ -70,8 +73,8 @@
"skip": true
},
"request-upload.any.js": {
"note": "no Float16Array",
"fail": [
"note": "Float16Array is valid from node v24.",
"flaky": [
"Fetch with POST with Float16Array body"
]
},
Expand Down
Loading