Skip to content

eventsource: deflake reconnectionTime tests #4406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Uzlopak merged 4 commits into from
Aug 13, 2025
Merged

eventsource: deflake reconnectionTime tests #4406

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5eef463
eventsource: also test for minimum time in reconnectionTime tests
Uzlopak Aug 12, 2025
aaaa427
more info
Uzlopak Aug 13, 2025
18f2292
less flaky?
Uzlopak Aug 13, 2025
b0010d8
use faketimers
Uzlopak Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 27 additions & 5 deletions test/eventsource/eventsource-connect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
const assert = require('node:assert')
const events = require('node:events')
const http = require('node:http')
const { test, describe } = require('node:test')
const { test, describe, after } = require('node:test')
const FakeTimers = require('@sinonjs/fake-timers')
const { EventSource, defaultReconnectionTime } = require('../../lib/web/eventsource/eventsource')
const { randomInt } = require('node:crypto')

Expand Down Expand Up @@ -184,6 +185,9 @@ describe('EventSource - received response must have content-type to be text/even
})

test('should try to connect again if server is unreachable', async () => {
const clock = FakeTimers.install()

after(() => clock.uninstall())
const reconnectionTime = defaultReconnectionTime
const domain = 'bad.n' + randomInt(1e10).toString(36) + '.proxy'

Expand All @@ -193,21 +197,29 @@ describe('EventSource - received response must have content-type to be text/even
eventSourceInstance.onerror = (error) => {
onerrorCalls.push(error)
}
clock.tick(reconnectionTime)

await events.once(eventSourceInstance, 'error')

const start = Date.now()
clock.tick(reconnectionTime)
await events.once(eventSourceInstance, 'error')
clock.tick(reconnectionTime)
await events.once(eventSourceInstance, 'error')
clock.tick(reconnectionTime)
await events.once(eventSourceInstance, 'error')
const end = Date.now()

eventSourceInstance.close()

assert.strictEqual(end - start < (3.5 * reconnectionTime), true)
assert.strictEqual(onerrorCalls.length, 4, 'Expected 4 error events')
assert.strictEqual(end - start, 3 * reconnectionTime, `Expected reconnection to happen after ${3 * reconnectionTime}ms, but took ${end - start}ms`)
})

test('should try to connect again if server is unreachable', async () => {
const reconnectionTime = 500
test('should try to connect again if server is unreachable, configure reconnectionTime', async () => {
const reconnectionTime = 1000
const clock = FakeTimers.install()
after(() => clock.uninstall())

const domain = 'bad.n' + randomInt(1e10).toString(36) + '.proxy'

Expand All @@ -216,16 +228,26 @@ describe('EventSource - received response must have content-type to be text/even
reconnectionTime
}
})

const onerrorCalls = []
eventSourceInstance.onerror = (error) => {
onerrorCalls.push(error)
}

await events.once(eventSourceInstance, 'error')

const start = Date.now()
clock.tick(reconnectionTime)
await events.once(eventSourceInstance, 'error')
clock.tick(reconnectionTime)
await events.once(eventSourceInstance, 'error')
clock.tick(reconnectionTime)
await events.once(eventSourceInstance, 'error')
const end = Date.now()

eventSourceInstance.close()

assert.strictEqual(end - start < (3.5 * reconnectionTime), true)
assert.strictEqual(onerrorCalls.length, 4, 'Expected 4 error events')
assert.strictEqual(end - start, 3 * reconnectionTime, `Expected reconnection to happen after ${3 * reconnectionTime}ms, but took ${end - start}ms`)
})
})
Loading