Skip to content

Disable SIMD for PPC64 architecture, add UNDICI_NO_WASM_SIMD env to facilitate testing #4530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Uzlopak merged 6 commits into from
Sep 8, 2025
Merged

Disable SIMD for PPC64 architecture, add UNDICI_NO_WASM_SIMD env to facilitate testing #4530

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
55d1c10
Disable SIMD for PPC64 architecture, add UNDICI_NO_WASM_SIMD env to f…
mcollina Sep 8, 2025
545b0b8
fixup
mcollina Sep 8, 2025
ce9f9bd
fixup
mcollina Sep 8, 2025
b6438b1
fixup
mcollina Sep 8, 2025
ef0e7e4
Update lib/dispatcher/client-h1.js
mcollina Sep 8, 2025
4fcd767
Apply suggestions from code review
Uzlopak Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions lib/dispatcher/client-h1.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,27 @@
const llhttpWasmData = process.env.JEST_WORKER_ID ? require('../llhttp/llhttp-wasm.js') : undefined

let mod
try {
mod = new WebAssembly.Module(require('../llhttp/llhttp_simd-wasm.js'))
} catch {
/* istanbul ignore next */

// We disable wasm SIMD on ppc64 as it seems to be broken on Power 9 architectures.
let useWasmSIMD = process.arch !== 'ppc64'

Check failure on line 70 in lib/dispatcher/client-h1.js

View workflow job for this annotation

GitHub Actions / Lint 

Trailing spaces not allowed
Comment thread
Uzlopak marked this conversation as resolved.
Outdated
// The Env Variable UNDICI_NO_WASM_SIMD allows explicitly overriding the default behavior
if (process.env.UNDICI_NO_WASM_SIMD === '1') {
useWasmSIMD = true
} else if (process.env.UNDICI_NO_WASM_SIMD === '0') {

Check failure on line 74 in lib/dispatcher/client-h1.js

View workflow job for this annotation

GitHub Actions / Lint 

Multiple spaces found before '('
Comment thread
Uzlopak marked this conversation as resolved.
Outdated
useWasmSIMD = false

Check failure on line 75 in lib/dispatcher/client-h1.js

View workflow job for this annotation

GitHub Actions / Lint 

'useWasmSIMD' is assigned a value but never used
}

if (useSIMD) {

Check failure on line 78 in lib/dispatcher/client-h1.js

View workflow job for this annotation

GitHub Actions / Lint 

'useSIMD' is not defined
Comment thread
Uzlopak marked this conversation as resolved.
Outdated
try {
mod = new WebAssembly.Module(require('../llhttp/llhttp_simd-wasm.js'))
/* istanbul ignore next */
} catch {
}
}

/* istanbul ignore next */
if (!mod) {
// We could check if the error was caused by the simd option not
// being enabled, but the occurring of this other error
// * https://github.com/emscripten-core/emscripten/issues/11495
Expand Down
Loading