Skip to content

perf(proxy-agent): avoid extra header allocations in auth guard #5164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcollina merged 2 commits into from
May 6, 2026
Merged

perf(proxy-agent): avoid extra header allocations in auth guard #5164

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe1be4a
perf(proxy-agent): avoid extra header allocations in auth guard
trivikr May 2, 2026
dd0c2b1
Merge branch 'nodejs:main' into proxy-agent-headers
trivikr May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions lib/dispatcher/proxy-agent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ const kProxyTls = Symbol('proxy tls settings')
const kConnectEndpoint = Symbol('connect endpoint function')
const kConnectEndpointHTTP1 = Symbol('connect endpoint function (http/1.1 only)')
const kTunnelProxy = Symbol('tunnel proxy')
const proxyAuthorization = 'proxy-authorization'

function defaultProtocolPort (protocol) {
return protocol === 'https:' ? 443 : 80
Expand Down Expand Up @@ -298,6 +299,10 @@ function buildHeaders (headers) {
const headersPair = {}

for (let i = 0; i < headers.length; i += 2) {
if (isProxyAuthorizationHeader(headers[i])) {
throwProxyAuthError()
}

headersPair[headers[i]] = headers[i + 1]
}

Expand All @@ -316,11 +321,23 @@ function buildHeaders (headers) {
* It should be removed in the next major version for performance reasons
*/
function throwIfProxyAuthIsSent (headers) {
const existProxyAuth = headers && Object.keys(headers)
.find((key) => key.toLowerCase() === 'proxy-authorization')
if (existProxyAuth) {
throw new InvalidArgumentError('Proxy-Authorization should be sent in ProxyAgent constructor')
for (const key in headers) {
if (isProxyAuthorizationHeader(key)) {
throwProxyAuthError()
}
}
}

/**
* @param {string} key
* @returns {boolean}
*/
function isProxyAuthorizationHeader (key) {
return key.length === proxyAuthorization.length && key.toLowerCase() === proxyAuthorization
}

function throwProxyAuthError () {
throw new InvalidArgumentError('Proxy-Authorization should be sent in ProxyAgent constructor')
}

module.exports = ProxyAgent
Loading