Skip to content

test: move cleanup from finally to after hooks#5194

Merged
mcollina merged 2 commits into
nodejs:mainfrom
trivikr:test-finally-close-after
May 5, 2026
Merged

test: move cleanup from finally to after hooks#5194
mcollina merged 2 commits into
nodejs:mainfrom
trivikr:test-finally-close-after

Conversation

@trivikr
Copy link
Copy Markdown
Member

@trivikr trivikr commented May 5, 2026

Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
@trivikr trivikr requested a review from mcollina May 5, 2026 02:52
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.26%. Comparing base (a07d945) to head (44aadd4).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5194      +/-   ##
==========================================
- Coverage   93.28%   93.26%   -0.02%     
==========================================
  Files         110      110              
  Lines       36313    36313              
==========================================
- Hits        33873    33866       -7     
- Misses       2440     2447       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 3d8ec00 into nodejs:main May 5, 2026
83 of 87 checks passed
@trivikr trivikr deleted the test-finally-close-after branch May 5, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants