Skip to content

fix(test): make issue-2898-comment.js assertion robust against flakiness #5208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcollina merged 1 commit into from
May 5, 2026
+10 −4
Merged

fix(test): make issue-2898-comment.js assertion robust against flakiness #5208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions test/fetch/issue-2898-comment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ const { test } = require('node:test')
const { Agent, Request, fetch } = require('../..')

test('issue #2828, RequestInit dispatcher options overrides Request input dispatcher', async (t) => {
t.plan(2)

class CustomAgentA extends Agent {
dispatch (options, handler) {
options.headers['x-my-header-a'] = 'hello'
Expand All @@ -23,19 +21,27 @@ test('issue #2828, RequestInit dispatcher options overrides Request input dispat
}

const server = createServer({ joinDuplicateHeaders: true }, (req, res) => {
t.assert.strictEqual(req.headers['x-my-header-a'], undefined)
t.assert.strictEqual(req.headers['x-my-header-b'], 'world')
res.end()
}).listen(0)

t.after(server.close.bind(server))
await once(server, 'listening')

const receivedHeaders = new Promise((resolve) => {
server.on('request', (req) => {
resolve(req.headers)
})
})

const request = new Request(`http://localhost:${server.address().port}`, {
dispatcher: new CustomAgentA()
})

await fetch(request, {
dispatcher: new CustomAgentB()
})

const headers = await receivedHeaders
t.assert.strictEqual(headers['x-my-header-a'], undefined)
t.assert.strictEqual(headers['x-my-header-b'], 'world')
})
Loading