Skip to content

test: deflake stream compat coverage#5209

Merged
trivikr merged 1 commit intomainfrom
fix/5207-stream-compat-flake
May 5, 2026
Merged

test: deflake stream compat coverage#5209
trivikr merged 1 commit intomainfrom
fix/5207-stream-compat-flake

Conversation

@mcollina
Copy link
Copy Markdown
Member

@mcollina mcollina commented May 5, 2026

This relates to...

Fixes: #5207

Rationale

test/stream-compat.js could finish with servers and clients still mid-lifecycle, which makes the unexpected disconnect guards race with teardown on CI.

Changes

  • switch the tests to await server startup explicitly with once(..., 'listening')
  • use per-test teardown via the original test context instead of file-level after() hooks
  • close active server connections before shutting test servers down
  • fully drain the response body in IncomingMessage before completing the test

Features

N/A

Bug Fixes

  • deflake test/stream-compat.js

Breaking Changes and Deprecations

N/A

Status

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.28%. Comparing base (20711c6) to head (33762c7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5209      +/-   ##
==========================================
+ Coverage   93.27%   93.28%   +0.01%     
==========================================
  Files         110      110              
  Lines       36349    36349              
==========================================
+ Hits        33904    33908       +4     
+ Misses       2445     2441       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trivikr trivikr merged commit da0eebc into main May 5, 2026
60 of 61 checks passed
@trivikr trivikr deleted the fix/5207-stream-compat-flake branch May 5, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[flaky] test\stream-compat.js

3 participants