fix(dispatcher): remove unreachable assert in writeBlob#5231
Merged
mcollina merged 1 commit intonodejs:mainfrom May 6, 2026
Merged
fix(dispatcher): remove unreachable assert in writeBlob#5231mcollina merged 1 commit intonodejs:mainfrom
mcollina merged 1 commit intonodejs:mainfrom
Conversation
The contentLength === body.size assert is always true because writeH1 and writeH2 overwrite contentLength with body.size (via util.bodyLength) before invoking writeBlob for blob bodies. Drop the dead assert and keep the if-guard as a defensive net. Refs nodejs#5153 Signed-off-by: SAY-5 <saiasish.cnp@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5231 +/- ##
==========================================
+ Coverage 93.27% 93.28% +0.01%
==========================================
Files 110 110
Lines 36353 36349 -4
==========================================
Hits 33909 33909
+ Misses 2444 2440 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Closes #5153
Rationale
The
assert(contentLength === body.size, ...)at the top ofwriteBlob(in bothclient-h1.jsandclient-h2.js) can never fire:writeH1/writeH2always overwritecontentLengthwithbody.sizeviautil.bodyLengthbefore invokingwriteBlobfor blob-like bodies. The follow-upif (contentLength != null && contentLength !== body.size)guard is also unreachable today, but is left in place as a defensive net for future refactors of the upstreamcontentLengthcomputation, matching option 2 in the issue.Changes
Features
N/A
Bug Fixes
assert(contentLength === body.size, ...)fromwriteBlobinlib/dispatcher/client-h1.jsandlib/dispatcher/client-h2.js.Breaking Changes and Deprecations
N/A
Status