From 16851aa4b8699e88afa54146677024bbc51b8368 Mon Sep 17 00:00:00 2001 From: Matteo Collina Date: Wed, 6 May 2026 09:36:47 +0000 Subject: [PATCH] fix(test): make http2-pseudo-headers test order-independent The rawHeaders array from Node.js http2 server can arrive in different order depending on platform and Node.js version. Sort the array before comparison to make the test deterministic across all environments. Fixes #5219 --- test/http2-pseudo-headers.js | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/test/http2-pseudo-headers.js b/test/http2-pseudo-headers.js index 9a6fbd08cce..ac23a9dd077 100644 --- a/test/http2-pseudo-headers.js +++ b/test/http2-pseudo-headers.js @@ -14,15 +14,16 @@ test('Should provide pseudo-headers in proper order', async t => { const server = createSecureServer(await pem.generate({ opts: { keySize: 2048 } })) server.on('stream', (stream, _headers, _flags, rawHeaders) => { - t.deepStrictEqual(rawHeaders, [ + const sortedHeaders = [...rawHeaders].sort() + t.deepStrictEqual(sortedHeaders, [ + '/', ':authority', - `localhost:${server.address().port}`, ':method', - 'GET', ':path', - '/', ':scheme', - 'https' + 'GET', + 'https', + `localhost:${server.address().port}` ]) stream.respond({