test(websocket): fully deflake send test#5236
Open
mcollina wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5236 +/- ##
=======================================
Coverage 93.45% 93.45%
=======================================
Files 110 110
Lines 37376 37376
=======================================
Hits 34928 34928
Misses 2448 2448 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
trivikr
approved these changes
Jul 4, 2026
mcollina
force-pushed
the
fix/websocket-send-flaky-5181-followup
branch
from
871481e to
4c4004f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
test/websocket/send.jsopen,message, andcloseevents deterministically withonce(...)Sending data after closeby subscribing before closingFollow-up to #5232
Related: #5181
Testing
npx borp -p "test/websocket/send.js"