Skip to content

test(websocket): fully deflake send test #5236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mcollina wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −5
Open

test(websocket): fully deflake send test #5236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions test/websocket/send.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,18 @@ async function closeWebSocket (ws) {
await close
}

async function closeWebSocketServer (server) {
for (const client of server.clients) {
client.terminate()
async function terminateWebSocket (ws) {
if (ws.readyState === WebSocket.CLOSED) {
return
}

const close = once(ws, 'close')
ws.terminate()
await close
}

async function closeWebSocketServer (server) {
await Promise.allSettled(Array.from(server.clients, terminateWebSocket))
await new Promise((resolve) => server.close(resolve))
}

Expand Down Expand Up @@ -122,12 +129,15 @@ test('Sending data after close', async (t) => {
t.assert.fail('Received unexpected message after closing the client')
})

const clientClose = once(ws, 'close')
const socketClose = once(socket, 'close')

ws.close()
ws.send('Some message')

await Promise.all([
once(ws, 'close'),
once(socket, 'close')
clientClose,
socketClose
])
})

Expand Down
Loading