test: deflake issue-5137 stream count assertion#5243
Open
trivikr wants to merge 1 commit intonodejs:mainfrom
Open
test: deflake issue-5137 stream count assertion#5243trivikr wants to merge 1 commit intonodejs:mainfrom
trivikr wants to merge 1 commit intonodejs:mainfrom
Conversation
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5243 +/- ##
=======================================
Coverage 93.27% 93.27%
=======================================
Files 110 110
Lines 36366 36366
=======================================
Hits 33922 33922
Misses 2444 2444 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mcollina
requested changes
May 6, 2026
| }) | ||
| ]) | ||
| clearTimeout(streamCountTimeout) | ||
|
|
Member
There was a problem hiding this comment.
Instead of this, we should assert that there are at least 3 chunks, not exactly 3.
Member
Author
There was a problem hiding this comment.
On line 32?
streamCount++
if (streamCount === 3) { // <-- This one
resolveStreamCount()
}Since it checks immediately after incrementing streamCount, the === should be okay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Fixes: #5218
Rationale
test/issue-5137.jscould intermittently fail on macOS GitHub runners because it asserted the server-side HTTP/2 stream count immediately after the client request rejected. With a short stream timeout, the final retry could be dispatched but the serverstreamevent might not have been observed yet.Changes
The test now waits until the server observes all 3 expected request attempts before asserting the stream count, with a bounded 1s fallback so real retry regressions still fail.
Features
N/A
Bug Fixes
N/A
Breaking Changes and Deprecations
N/A
Status