fix: prevent node-fetch test server close from hanging on Windows#5246
Merged
fix: prevent node-fetch test server close from hanging on Windows#5246
Conversation
The TestServer.stop() method called server.close() and waited for the 'close' event, but on Windows lingering socket connections could prevent the event from firing, causing the entire test module to time out with 'test failed'. Adding closeAllConnections() before close() ensures all active connections are destroyed, allowing the server to close promptly. Fixes #5178
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5246 +/- ##
=======================================
Coverage 93.27% 93.27%
=======================================
Files 110 110
Lines 36366 36366
=======================================
Hits 33922 33922
Misses 2444 2444 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Fixes: #5178 |
trivikr
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
test/node-fetch/main.jssuite was flaking on Windows with:This was caused by
TestServer.stop()callingserver.close()and awaiting the'close'event, but on Windows, lingering socket connections could prevent the'close'event from firing. Theafterhook would hang until the test runner's module-level timeout killed it, causing the entire test module to fail.Fix
Call
server.closeAllConnections()beforeserver.close()inTestServer.stop()to ensure all active connections are destroyed before attempting to close the server. This is a standard pattern for test server teardown and is safe becausecloseAllConnections()was added in Node.js 18.2.0 and the project already requires Node.js 18+.Testing
npm run test:node-fetchpasses (176 pass, 13 skipped, 0 fail)