Skip to content

test: only fail max-listener checks on max-listener warnings #5253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trivikr wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

test: only fail max-listener checks on max-listener warnings #5253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/client-pipelining.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ test('20 times GET with pipelining 10', async (t) => {

// needed to check for a warning on the maxListeners on the socket
function onWarning (warning) {
if (!/ExperimentalWarning/.test(warning)) {
if (warning.name === 'MaxListenersExceededWarning') {
t.fail()
}
}
Expand Down
2 changes: 1 addition & 1 deletion test/client-write-max-listeners.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ test('socket close listener does not leak', async (t) => {
}

function onWarning (warning) {
if (!/ExperimentalWarning/.test(warning)) {
if (warning.name === 'MaxListenersExceededWarning') {
t.fail()
}
}
Expand Down
2 changes: 1 addition & 1 deletion test/promises.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ test('20 times GET with pipelining 10, async await support', async (t) => {

// needed to check for a warning on the maxListeners on the socket
function onWarning (warning) {
if (!/ExperimentalWarning/.test(warning)) {
if (warning.name === 'MaxListenersExceededWarning') {
t.fail()
}
}
Expand Down
Loading