Skip to content

test: retry crashed cache-test workers once#5294

Merged
mcollina merged 1 commit into
nodejs:mainfrom
trivikr:test-cache-interceptor-fix-2
May 12, 2026
Merged

test: retry crashed cache-test workers once#5294
mcollina merged 1 commit into
nodejs:mainfrom
trivikr:test-cache-interceptor-fix-2

Conversation

@trivikr
Copy link
Copy Markdown
Member

@trivikr trivikr commented May 12, 2026

This relates to...

Refs: #5199

Rationale

test:cache-tests can intermittently fail when a worker process exits from a native/runtime crash, such as Windows exit code 3221226505. Retrying once lets transient worker crashes recover while preserving normal test failures.

Changes

  • Retry a crashed cache-tests worker once.
  • Keep regular test failures, such as exit code 1, failing without retry.

Features

N/A

Bug Fixes

N/A

Breaking Changes and Deprecations

N/A

Status

Assisted-by: openai:gpt-5.5

Assisted-by: openai:gpt-5.5
Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.25%. Comparing base (df5ded9) to head (696668b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5294      +/-   ##
==========================================
- Coverage   93.26%   93.25%   -0.01%     
==========================================
  Files         110      110              
  Lines       36547    36547              
==========================================
- Hits        34085    34082       -3     
- Misses       2462     2465       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 45f7bd3 into nodejs:main May 12, 2026
85 of 87 checks passed
@github-actions github-actions Bot mentioned this pull request May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants