Skip to content

test: stabilize tls-cert-leak regression#5306

Merged
mcollina merged 1 commit into
mainfrom
fix/5268-tls-cert-leak-flaky
May 16, 2026
Merged

test: stabilize tls-cert-leak regression#5306
mcollina merged 1 commit into
mainfrom
fix/5268-tls-cert-leak-flaky

Conversation

@mcollina
Copy link
Copy Markdown
Member

Description

Stabilizes test/tls-cert-leak.js by removing the per-request AbortSignal.timeout(2000).

The test already has a test-level timeout, and creating a fresh timeout signal for every failed TLS request retains enough short-lived objects to make this memory regression test flaky under the current runner.

This also recognizes UNABLE_TO_VERIFY_LEAF_SIGNATURE, which is the error code produced locally for the self-signed certificate fixture.

Fixes #5268

Testing

  • node --expose-gc test/tls-cert-leak.js
  • for i in $(seq 1 10); do node --expose-gc test/tls-cert-leak.js; done
  • npx borp --expose-gc -p "test/tls-cert-leak.js"

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.23%. Comparing base (8755693) to head (54b8781).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5306   +/-   ##
=======================================
  Coverage   93.23%   93.23%           
=======================================
  Files         110      110           
  Lines       36575    36575           
=======================================
+ Hits        34100    34101    +1     
+ Misses       2475     2474    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollina mcollina merged commit adf9d32 into main May 16, 2026
66 of 67 checks passed
@mcollina mcollina deleted the fix/5268-tls-cert-leak-flaky branch May 16, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[flaky] test\tls-cert-leak.js

3 participants