Skip to content

refactor: replace tspl with node:test t.plan in connect-timeout tests#5518

Open
mcollina wants to merge 1 commit into
mainfrom
remove-tspl-connect-timeout
Open

refactor: replace tspl with node:test t.plan in connect-timeout tests#5518
mcollina wants to merge 1 commit into
mainfrom
remove-tspl-connect-timeout

Conversation

@mcollina

@mcollina mcollina commented Jul 5, 2026

Copy link
Copy Markdown
Member

Summary

Replace @matteo.collina/tspl with Node.js core t.plan() in test/connect-timeout.js.

Changes

  • Removed tspl import and all tspl(...) calls
  • describe block: uses Promise.withResolvers() + raw assert.* (since describe has no test context)
  • assertConnectTimeout helper: t.plan(3) + t.assert.* instead of tspl(t, {plan:3})
  • autoSelectFamily test: t.plan(5) + wrapped in await new Promise(...) to keep the test function alive for async callback assertions

Testing

  • npx borp -p "test/connect-timeout.js"
  • npx eslint test/connect-timeout.js

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.44%. Comparing base (cb4c2f1) to head (ac5b1c4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5518      +/-   ##
==========================================
- Coverage   93.44%   93.44%   -0.01%     
==========================================
  Files         110      110              
  Lines       37328    37328              
==========================================
- Hits        34881    34880       -1     
- Misses       2447     2448       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants