Skip to content

Commit fbe5111

Browse files
flakey5avivkeller
andauthored
Apply suggestions from code review
Co-authored-by: Aviv Keller <me@aviv.sh>
1 parent 64e48f0 commit fbe5111

1 file changed

Lines changed: 7 additions & 10 deletions

File tree

onboarding/web-infra.md

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,11 @@ To start the nomination process, see [GOVERNANCE.md](../GOVERNANCE.md).
77

88
## Tasks
99

10-
- [ ] The nominee should open a pull request in [nodejs/web-team](https://github.com/nodejs/web-team) adding themselves to the [MEMBERS.md](https://github.com/nodejs/web-team/blob/main/MEMBERS.md#nodejs-web-infra-team-nodejsweb-infra) document.
11-
- [ ] Nominee should include this list in the pull request's body to keep track of what has been completed for their onboarding. The pull request should not be merged until the onboarding tasks have been completed.
12-
- [ ] Please link any additional issues or pull requests back to this one for record keeping purposes.
13-
- [ ] A Web Admin should add the nominee to the [@nodejs/web-infra](https://github.com/orgs/nodejs/teams/web-infra) team.
10+
- [ ] Add the **Nominee** to the @nodejs/web-infra team on GitHub.
1411
- [ ] The nominee should open an issue in [nodejs/admin](https://github.com/nodejs/admin) requesting access to the Web Infra 1Password vault.
15-
- [ ] A Web Admin should invite the nominee to Node.js' Sentry account.
16-
- [ ] The nominee should enable physical or passkey 2FA on their Sentry account.
17-
- [ ] A Web Admin should invite the nominee to Node.js' Vercel account.
12+
- [ ] Grant the **Nominee** access to Sentry.
13+
- [ ] The **Nominee** should enable physical or passkey 2FA on their Sentry account.
14+
- [ ] Grant the **Nominee** access to Vercel.
1815
- [ ] The nominee should enable physical or passkey 2FA on their Vercel account.
1916
- [ ] The **Nominee** should add their email to the following aliases (by opening a PR in [nodejs/email](https://github.com/nodejs/email))
2017
- [ ] [`nodejs-crowdin`](https://github.com/nodejs/email/blob/main/iojs.org/aliases.json#L174)
@@ -23,9 +20,9 @@ To start the nomination process, see [GOVERNANCE.md](../GOVERNANCE.md).
2320

2421
### Recommendations
2522

26-
- [ ] A Web Admin should recommend the nominee have some form of physical 2FA (i.e. Yubikey) or passkey enabled on their GitHub account
27-
- [ ] A Web Admin should recommend any SSH or GPG key attached to their GitHub account have passphrases or be stored on a physical 2FA device.
28-
- [ ] A Web Admin should recommend the nominee sign their Git commits.
23+
- [ ] The **Nominee** should have some form of physical 2FA (i.e. Yubikey) or passkey enabled on their GitHub account.
24+
- [ ] The **Nominee** should have a SSH or GPG key attached to their GitHub account have passphrases or be stored on a physical 2FA device.
25+
- [ ] The **Nominee** should sign their Git commits.
2926

3027
## Notes
3128

0 commit comments

Comments
 (0)