feat(governance): add general PR policies#112
Conversation
Added policies for pull requests, including atomic changes and fast-track approvals.
There was a problem hiding this comment.
Pull request overview
Adds governance text to formalize pull request expectations for the Node.js Web Team, addressing fast-track approvals and PR scope/relevancy.
Changes:
- Introduces an “Atomic Pull Requests” policy to encourage single-purpose PRs.
- Updates the “Fast-Track Policy” to require approval from someone other than the author and fast-track requester, with an exception path for urgent changes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
|
Should I also document our auto-merge policy? |
I don't think so, I'm not sure we have a policy there, it is just safe automation around our regular merge policy? |
MattIPv4
left a comment
MattIPv4
left a comment
There was a problem hiding this comment.
Putting an explicit block on this as I would like to make sure I have the time to review this once I'm back from adventuring
Yes, to clarify, I meant noting that for non-fork PRs, that label is also an option |
Ah. Sure! |
Fixes #97
Fixes #98
As discussed in today's meeting with @bmuenzenmeyer