Skip to content

Commit 2e44b14

Browse files
authored
Merge pull request #464 from pacostas/update-node-versions
feat!: remove Node 20 support
2 parents cc0f3f6 + 9cdef37 commit 2e44b14

4 files changed

Lines changed: 44 additions & 28 deletions

File tree

Lines changed: 18 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,43 +1,52 @@
11
name: Node.js CI
22

33
on:
4-
push:
5-
branches: [ main ]
64
pull_request:
7-
branches: [ main ]
5+
branches: [main]
6+
workflow_dispatch:
7+
8+
permissions:
9+
contents: read
10+
11+
concurrency:
12+
group: nodejs-ci-${{ github.workflow }}-${{ github.ref }}
13+
cancel-in-progress: true
814

915
jobs:
1016
build:
11-
1217
runs-on: ubuntu-latest
1318

1419
strategy:
20+
fail-fast: false
1521
matrix:
16-
node-version: [20.x, 22.x, 24.x]
22+
node-version: [22.x, 24.x, 26.x]
1723

1824
steps:
1925
- uses: actions/checkout@v6
2026
- name: Use Node.js ${{ matrix.node-version }}
2127
uses: actions/setup-node@v6
2228
with:
2329
node-version: ${{ matrix.node-version }}
30+
2431
- run: npm ci
2532
- run: npm test
2633
- run: npx @pkgjs/support@latest validate
2734
- run: node_modules/nyc/bin/nyc.js report --reporter=lcovonly
35+
2836
- name: Coveralls Parallel
29-
uses: coverallsapp/github-action@master
37+
uses: coverallsapp/github-action@v2
3038
with:
31-
github-token: ${{ secrets.github_token }}
39+
github-token: ${{ secrets.GITHUB_TOKEN }}
3240
flag-name: run-${{ matrix.node-version }}
3341
parallel: true
3442

3543
finish:
44+
name: Node.js CI
3645
needs: build
3746
runs-on: ubuntu-latest
3847
steps:
3948
- name: Coveralls Finished
40-
uses: coverallsapp/github-action@master
49+
uses: coverallsapp/github-action@v2
4150
with:
42-
github-token: ${{ secrets.github_token }}
51+
github-token: ${{ secrets.GITHUB_TOKEN }}
4352
parallel-finished: true

.github/workflows/release-please.yml

Lines changed: 23 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,38 @@
1-
on:
2-
push:
3-
branches:
4-
- main
51
name: release-please
2+
on:
3+
push:
4+
branches:
5+
- main
6+
7+
permissions:
8+
contents: write
9+
issues: write
10+
pull-requests: write
11+
id-token: write
12+
613
jobs:
714
release-please:
815
runs-on: ubuntu-latest
16+
outputs:
17+
release_created: ${{ steps.release.outputs.release_created }}
918
steps:
10-
- uses: GoogleCloudPlatform/release-please-action@v5
19+
- uses: googleapis/release-please-action@v4
1120
id: release
1221
with:
13-
token: ${{ secrets.GITHUB_TOKEN }}
1422
release-type: node
15-
package-name: openshift-rest-client
1623

24+
publish:
25+
runs-on: ubuntu-latest
26+
needs: release-please
27+
if: needs.release-please.outputs.release_created == 'true'
28+
29+
steps:
1730
- uses: actions/checkout@v6
18-
if: ${{ steps.release.outputs.release_created }}
1931
- uses: actions/setup-node@v6
2032
with:
21-
node-version: 20
22-
registry-url: 'https://registry.npmjs.org'
23-
if: ${{ steps.release.outputs.release_created }}
33+
node-version: 24
34+
registry-url: "https://registry.npmjs.org"
35+
package-manager-cache: false
2436
- run: npm ci
25-
if: ${{ steps.release.outputs.release_created }}
2637
- run: npm test
27-
if: ${{ steps.release.outputs.release_created }}
2838
- run: npm publish
29-
env:
30-
NODE_AUTH_TOKEN: ${{secrets.OPENSHIFT_REST_CLIENT_PUBLISH}}
31-
if: ${{ steps.release.outputs.release_created }}

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,11 @@
3232
}
3333
],
3434
"engines": {
35-
"node": "^24 || ^22 || ^20"
35+
"node": "^26 || ^24 || ^22"
3636
},
3737
"repository": {
3838
"type": "git",
39-
"url": "nodeshift/openshift-rest-client"
39+
"url": "git+https://github.com/nodeshift/openshift-rest-client"
4040
},
4141
"bugs": "https://github.com/nodeshift/openshift-rest-client/issues",
4242
"license": "Apache-2.0",

0 commit comments

Comments
 (0)