fixing the CI

Author: edsadr

.github/workflows/docker-tests.yml .github/workflows/pnpm-tests.yml.github/workflows/docker-tests.yml renamed to .github/workflows/pnpm-tests.yml

@@ -14,7 +14,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [20, 22, 24]
+        node-version: [22, 24]
 
     steps:
       - name: Checkout code

lib/detectors/version-managers/n.js

@@ -1,7 +1,8 @@
 const fs = require('node:fs')
 const path = require('node:path')
-const { execSync } = require('node:child_process')
-const { isWindows, findExecutable, extractVersionFromPath, normalizePathSeparators } = require('../../platform-utils')
+const { isWindows } = require('../../platform-utils')
+const platformUtils = require('../../platform-utils')
+const childProcess = require('node:child_process')
 
 /**
  * Try to detect Node.js version from n (Node.js version manager by TJ)
@@ -73,11 +74,11 @@ function detectNodeVersionFromN () {
 
     // Strategy 4: Check where node points to n-managed version (cross-platform)
     try {
-      const nodePath = findExecutable('node')
+      const nodePath = platformUtils.findExecutable('node')
       if (nodePath) {
-        const normalizedPath = normalizePathSeparators(nodePath)
+        const normalizedPath = platformUtils.normalizePathSeparators(nodePath)
         if (normalizedPath.includes('/n/versions/node/')) {
-          const version = extractVersionFromPath(normalizedPath)
+          const version = platformUtils.extractVersionFromPath(normalizedPath)
           if (version) {
             return `v${version}`
           }
@@ -89,13 +90,13 @@ function detectNodeVersionFromN () {
 
     // Strategy 5: Try n command as fallback (simplified, no shell redirection)
     try {
-      const version = execSync('n bin', {
+      const version = childProcess.execSync('n bin', {
         encoding: 'utf-8',
         stdio: ['pipe', 'pipe', 'ignore'],
         timeout: 2000
       }).trim()
 
-      const extractedVersion = extractVersionFromPath(normalizePathSeparators(version))
+      const extractedVersion = platformUtils.extractVersionFromPath(platformUtils.normalizePathSeparators(version))
       if (extractedVersion) {
         return `v${extractedVersion}`
       }

package.json

@@ -28,7 +28,7 @@
   "engines": {
     "node": ">=22.0.0"
   },
-  "packageManager": "pnpm@10.20.0",
+  "packageManager": "pnpm@10.22.0",
   "publishConfig": {
     "registry": "http://packages-internal.nodesource.io"
   },

test/version-managers-mocked.test.js

@@ -1,5 +1,9 @@
 const { test, describe } = require('node:test')
 const assert = require('node:assert')
+const sinon = require('sinon')
+const fs = require('node:fs')
+const childProcess = require('node:child_process')
+const platformUtils = require('../lib/platform-utils')
 
 describe('Version Managers Mocked - Module Imports', () => {
   test('nvm detector can be imported', () => {
@@ -95,14 +99,29 @@ describe('Version Managers Mocked - Default Behavior', () => {
   test('n returns null when not configured', () => {
     const originalNPrefix = process.env.N_PREFIX
 
+    // Mock dependencies to ensure clean environment regardless of actual system state
+    const existsSyncStub = sinon.stub(fs, 'existsSync')
+    const findExecutableStub = sinon.stub(platformUtils, 'findExecutable')
+    const execSyncStub = sinon.stub(childProcess, 'execSync')
+
     try {
       delete process.env.N_PREFIX
 
+      // Configure mocks to simulate "not found" state
+      existsSyncStub.returns(false)
+      findExecutableStub.returns(null)
+      execSyncStub.throws(new Error('Command failed'))
+
       const { detectNodeVersionFromN } = require('../lib/detectors/version-managers/n')
       const version = detectNodeVersionFromN()
       assert.strictEqual(version, null, 'Should return null when N not configured')
     } finally {
       if (originalNPrefix) process.env.N_PREFIX = originalNPrefix
+
+      // Restore stubs
+      existsSyncStub.restore()
+      findExecutableStub.restore()
+      execSyncStub.restore()
     }
   })
 })