Fixup

Author: santigimeno

lib/internal/nsolid_diag.js

@@ -394,10 +394,10 @@ dc.subscribe('tracing:fastify.request.handler:start', ({ request, route }) => {
 // Subscribe to HTTP response finish to capture Express routes
 // Express sets req.route.path during request processing, available by response time
 dc.subscribe('http.server.response.finish', ({ request, response }) => {
-  if (request?.route?.path && !request[nsolid_route_s]) {
+  const routePath = request?.route?.path;
+  if (typeof routePath === 'string' && !request[nsolid_route_s]) {
     // Compose full route path including mounted router prefixes
     const baseUrl = request.baseUrl || '';
-    const routePath = request.route.path;
     // Avoid double slashes when concatenating (e.g., baseUrl ends with / and routePath starts with /)
     const fullPath = baseUrl.endsWith('/') && routePath.startsWith('/') ?
       baseUrl + routePath.slice(1) :

test/integrations/express/v4/test-http-route.mjs

@@ -1,5 +1,6 @@
 // Flags: --expose-internals
 import { mustSucceed } from '../../../common/index.mjs';
+import { mustNotCall } from '../../../common/index.mjs';
 import assert from 'node:assert';
 import { existsSync } from 'node:fs';
 import { fileURLToPath } from 'node:url';
@@ -110,6 +111,10 @@ async function runTest() {
     res.json({ status: 'ok' });
   });
 
+  app.get(/^\/regex\/(\d+)$/, (req, res) => {
+    res.json({ userId: req.params[0] });
+  });
+
   // Track connections for forceful close
   const connections = new Set();
   const server = await new Promise((resolve) => {
@@ -148,6 +153,8 @@ async function runTest() {
     });
   });
 
+  process.once('uncaughtException', mustNotCall('regex Express routes must not throw in http.server.response.finish'));
+
   // Make HTTP requests to trigger routes
   console.log('Making HTTP requests...');
 
@@ -166,6 +173,11 @@ async function runTest() {
   assert.strictEqual(response.status, 200);
   console.log('Requested /health');
 
+  // Request to regex route - should not set http.route or throw
+  response = await fetch(`http://127.0.0.1:${serverPort}/regex/789`);
+  assert.strictEqual(response.status, 200);
+  console.log('Requested /regex/789');
+
   // Wait for all metrics to be reported
   await metricsPromise;
 

test/integrations/express/v5/test-http-route.mjs

@@ -1,5 +1,6 @@
 // Flags: --expose-internals
 import { mustSucceed } from '../../../common/index.mjs';
+import { mustNotCall } from '../../../common/index.mjs';
 import assert from 'node:assert';
 import { existsSync } from 'node:fs';
 import { fileURLToPath } from 'node:url';
@@ -110,6 +111,10 @@ async function runTest() {
     res.json({ status: 'ok' });
   });
 
+  app.get(/^\/regex\/(\d+)$/, (req, res) => {
+    res.json({ userId: req.params[0] });
+  });
+
   // Track connections for forceful close
   const connections = new Set();
   const server = await new Promise((resolve) => {
@@ -148,6 +153,8 @@ async function runTest() {
     });
   });
 
+  process.once('uncaughtException', mustNotCall('regex Express routes must not throw in http.server.response.finish'));
+
   // Make HTTP requests to trigger routes
   console.log('Making HTTP requests...');
 
@@ -166,6 +173,11 @@ async function runTest() {
   assert.strictEqual(response.status, 200);
   console.log('Requested /health');
 
+  // Request to regex route - should not set http.route or throw
+  response = await fetch(`http://127.0.0.1:${serverPort}/regex/789`);
+  assert.strictEqual(response.status, 200);
+  console.log('Requested /regex/789');
+
   // Wait for all metrics to be reported
   await metricsPromise;
 

test/integrations/fastify/v5/test-http-route.mjs

@@ -18,8 +18,7 @@ const __dirname = dirname(fileURLToPath(import.meta.url));
 
 // Skip test if dependencies not installed
 if (!existsSync(join(__dirname, 'node_modules'))) {
-  console.log('SKIP: node_modules not found. Run "make test-integrations-prereqs" first.');
-  process.exit(0);
+  throw new Error('SKIP: node_modules not found. Run "make test-integrations-prereqs" first.');
 }
 
 const { default: Fastify } = await import('fastify');