Skip to content

Commit 414cb01

Browse files
authored
update: Node 16 is dead, moving to 18 (#258)
1 parent ab2e5b2 commit 414cb01

File tree

5 files changed

+9
-8
lines changed

5 files changed

+9
-8
lines changed

.devcontainer/devcontainer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// README at: https://github.com/devcontainers/templates/tree/main/src/javascript-node-postgres
33
{
44
"name": "Node Vault",
5-
"image": "mcr.microsoft.com/devcontainers/javascript-node:0-18",
5+
"image": "mcr.microsoft.com/devcontainers/javascript-node:1-18-bookworm",
66
"workspaceFolder": "/workspaces/${localWorkspaceFolderBasename}",
77
// Features to add to the dev container. More info: https://containers.dev/features.
88
// "features": {},

.github/workflows/lint-and-test.yaml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@ jobs:
1212
runs-on: ubuntu-latest
1313
steps:
1414
- uses: actions/checkout@v3
15-
# Use node 16
15+
# Use node 18
1616
- uses: actions/setup-node@v3
1717
with:
18-
node-version: 16
18+
node-version: 18
1919
- name: Install dependencies
2020
# Install deps from lockfile
2121
run: npm ci
@@ -29,7 +29,8 @@ jobs:
2929
strategy:
3030
matrix:
3131
# We verify compatibility for current and previous LTS
32-
node_version: [16, 18]
32+
# Jun 2025 -> Still supporting node 16 tho it was EOL on September 11, 2023
33+
node_version: [16, 18, 20, 22, 23, 24]
3334
name: "[ Node ${{ matrix.node_version }} ] Run tests and push to codecov"
3435
env:
3536
NODE_VERSION: ${{ matrix.node_version }}

Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ SHELL ["/bin/bash", "--login", "-c"]
77
RUN apt update && apt install -y curl
88
# Get optional env var to set node version
99
ARG SET_NODE_VERSION
10-
# Set default to node 16.20.0
11-
ENV NODE_VERSION ${SET_NODE_VERSION:-16.20.0}
10+
# Set default to node 18.20.8
11+
ENV NODE_VERSION ${SET_NODE_VERSION:-18.20.8}
1212
RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.35.3/install.sh | bash
1313
RUN nvm install $NODE_VERSION
1414

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"docs": "docco --output docs src/*.js"
1414
},
1515
"engines": {
16-
"node": ">= 16.0.0"
16+
"node": ">= 18.0.0"
1717
},
1818
"directories": {
1919
"example": "./example",

0 commit comments

Comments
 (0)