Fix #175: strip trailing slash from endpoint to prevent double slashes in URIs

Co-authored-by: aviadhahami <7353632+aviadhahami@users.noreply.github.com>
Agent-Logs-Url: https://github.com/nodevault/node-vault/sessions/18acbdc1-2e5a-4a10-8209-9c26eefda931

Author: Copilot

src/index.js

@@ -198,6 +198,8 @@ module.exports = (config = {}) => {
     client.namespace = config.namespace || process.env.VAULT_NAMESPACE;
     client.kubernetesPath = config.kubernetesPath || 'kubernetes';
 
+    client.endpoint = client.endpoint.replace(/\/$/, '');
+
     const requestSchema = {
         type: 'object',
         properties: {

test/unit.js

@@ -87,6 +87,32 @@ describe('node-vault', () => {
         });
     });
 
+    describe('client initialization', () => {
+        it('should not trim endpoint if no trailing slash', () => {
+            const defaultsStub = sinon.stub();
+            const vaultConfig = {
+                endpoint: 'http://localhost:8200',
+                'request-promise': {
+                    defaults: defaultsStub,
+                },
+            };
+            const vault = index(vaultConfig);
+            vault.endpoint.should.equal('http://localhost:8200');
+        });
+
+        it('should trim endpoint if trailing slash', () => {
+            const defaultsStub = sinon.stub();
+            const vaultConfig = {
+                endpoint: 'http://localhost:8200/',
+                'request-promise': {
+                    defaults: defaultsStub,
+                },
+            };
+            const vault = index(vaultConfig);
+            vault.endpoint.should.equal('http://localhost:8200');
+        });
+    });
+
     describe('client', () => {
         let request = null;
         let response = null;