Move Request types to dependencies & fix functionConf type#146
Closed
Kamahl19 wants to merge 4 commits into
Closed
Move Request types to dependencies & fix functionConf type#146Kamahl19 wants to merge 4 commits into
Kamahl19 wants to merge 4 commits into
Conversation
Author
Kamahl19
changed the title
Codecov Report
@@ Coverage Diff @@
## master #146 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 139 139
Branches 34 34
=========================================
Hits 139 139 Continue to review full report at Codecov.
|
Author
|
@kr1sp1n Could you please take a look on this one? It fixes 2 bugs with types introduced lately. |
Collaborator
|
@Kamahl19 do you mind removing the |
aviadhahami
requested changes
Nov 10, 2022
| "index.d.ts" | ||
| ], | ||
| "dependencies": { | ||
| "@types/request": "^2.48.1", |
Merged
Collaborator
|
addressed in #257 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@types/request needs to be a dependency instead of devDependency. If we build a library with node-vault as dependency, @types/request are missing
It also fixes functionConf type