Skip to content

fix Namespace.clone()/.inherit() not honoring .ordered property like .model() #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
illes wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix Namespace.clone()/.inherit() not honoring .ordered property like .model() #619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions flask_restplus/namespace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,11 +164,12 @@ def extend(self, name, parent, fields):

:deprecated: since 0.9. Use :meth:`clone` instead
'''
cls = OrderedModel if self.ordered else Model
if isinstance(parent, list):
parents = parent + [fields]
model = Model.extend(name, *parents)
model = cls.extend(name, *parents)
else:
model = Model.extend(name, parent, fields)
model = cls.extend(name, parent, fields)
return self.add_model(name, model)

def clone(self, name, *specs):
Expand All @@ -181,7 +182,8 @@ def clone(self, name, *specs):
.. seealso:: :meth:`Model.clone`

'''
model = Model.clone(name, *specs)
cls = OrderedModel if self.ordered else Model
model = cls.clone(name, *specs)
return self.add_model(name, model)

def inherit(self, name, *specs):
Expand All @@ -190,7 +192,8 @@ def inherit(self, name, *specs):

.. seealso:: :meth:`Model.inherit`
'''
model = Model.inherit(name, *specs)
cls = OrderedModel if self.ordered else Model
model = cls.inherit(name, *specs)
return self.add_model(name, model)

def expect(self, *inputs, **kwargs):
Expand Down