Skip to content

Commit 251867d

Browse files
committed
🐛 fix(alembic): dispose engine
fix #33
1 parent e25e449 commit 251867d

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

nonebot_plugin_orm/templates/generic/env.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,8 @@ async def run_migrations_online() -> None:
7070
async with engine.connect() as connection:
7171
await connection.run_sync(do_run_migrations)
7272

73+
await engine.dispose()
74+
7375

7476
if context.is_offline_mode():
7577
run_migrations_offline()

nonebot_plugin_orm/templates/multidb/env.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ async def run_migrations_online() -> None:
113113
raise
114114
finally:
115115
await asyncio.gather(*(conn.close() for conn in conns.values()))
116-
116+
await asyncio.gather(*(engine.dispose() for engine in engines.values()))
117117

118118
if context.is_offline_mode():
119119
run_migrations_offline()

0 commit comments

Comments
 (0)